* [PATCH] drm/mediatek: fix a typo @ 2016-09-29 3:22 Bibby Hsieh 2016-09-29 4:01 ` CK Hu 0 siblings, 1 reply; 5+ messages in thread From: Bibby Hsieh @ 2016-09-29 3:22 UTC (permalink / raw) To: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel, linux-mediatek Cc: linux-kernel, Cawa Cheng, Mao Huang, Yingjoe Chen, Sascha Hauer, linux-arm-kernel Fix the typo: OD_RELAYMODE->OD_CFG Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index df33b3c..aa5f20f 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, unsigned int bpc) { writel(w << 16 | h, comp->regs + DISP_OD_SIZE); - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); + writel(OD_RELAYMODE, comp->regs + OD_CFG); mtk_dither_set(comp, bpc, DISP_OD_CFG); } -- 1.7.9.5 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: fix a typo 2016-09-29 3:22 [PATCH] drm/mediatek: fix a typo Bibby Hsieh @ 2016-09-29 4:01 ` CK Hu 2016-09-29 8:46 ` Matthias Brugger 0 siblings, 1 reply; 5+ messages in thread From: CK Hu @ 2016-09-29 4:01 UTC (permalink / raw) To: Bibby Hsieh Cc: linux-kernel, Sascha Hauer, Daniel Vetter, Cawa Cheng, dri-devel, Mao Huang, linux-mediatek, Matthias Brugger, Yingjoe Chen, linux-arm-kernel Acked-by: CK Hu <ck.hu@mediatek.com> On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote: > Fix the typo: OD_RELAYMODE->OD_CFG > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index df33b3c..aa5f20f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, > unsigned int bpc) > { > writel(w << 16 | h, comp->regs + DISP_OD_SIZE); > - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); > + writel(OD_RELAYMODE, comp->regs + OD_CFG); > mtk_dither_set(comp, bpc, DISP_OD_CFG); > } > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: fix a typo 2016-09-29 4:01 ` CK Hu @ 2016-09-29 8:46 ` Matthias Brugger 2016-09-30 3:11 ` Bibby Hsieh 0 siblings, 1 reply; 5+ messages in thread From: Matthias Brugger @ 2016-09-29 8:46 UTC (permalink / raw) To: CK Hu, Bibby Hsieh Cc: David Airlie, Daniel Vetter, dri-devel, linux-mediatek, Yingjoe Chen, Cawa Cheng, Daniel Kurtz, Philipp Zabel, YT Shen, Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel, Sascha Hauer On 29/09/16 06:01, CK Hu wrote: > Acked-by: CK Hu <ck.hu@mediatek.com> > > On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote: >> Fix the typo: OD_RELAYMODE->OD_CFG >> Although it is quite clear what the patch does, could you write one sentence to explain what it does. Maybe explain even which effect it has, which error get fixed etc. As we are getting public available boards now, we should take more care about fixes. If you have a fix for a commit introduced in an earlier version of linux and it should be fixed for this version as well (e.g. v4.6 does have the feature but it does not work correctly) then please add these two lines before your Signed-off-by: Fixes: <commit-hash> ("<commit subject line>") Cc: stable@vger.kernel.org # v4.6+ Where v4.6+ stands for the oldest version where this should get fixed. Thanks a lot, Matthias >> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com> >> --- >> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >> index df33b3c..aa5f20f 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >> @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, >> unsigned int bpc) >> { >> writel(w << 16 | h, comp->regs + DISP_OD_SIZE); >> - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); >> + writel(OD_RELAYMODE, comp->regs + OD_CFG); >> mtk_dither_set(comp, bpc, DISP_OD_CFG); >> } >> > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: fix a typo 2016-09-29 8:46 ` Matthias Brugger @ 2016-09-30 3:11 ` Bibby Hsieh 2016-10-03 8:46 ` Matthias Brugger 0 siblings, 1 reply; 5+ messages in thread From: Bibby Hsieh @ 2016-09-30 3:11 UTC (permalink / raw) To: Matthias Brugger Cc: CK Hu, David Airlie, Daniel Vetter, dri-devel, linux-mediatek, Yingjoe Chen, Cawa Cheng, Daniel Kurtz, Philipp Zabel, YT Shen, Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel, Sascha Hauer On Thu, 2016-09-29 at 10:46 +0200, Matthias Brugger wrote: > > On 29/09/16 06:01, CK Hu wrote: > > Acked-by: CK Hu <ck.hu@mediatek.com> > > > > On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote: > >> Fix the typo: OD_RELAYMODE->OD_CFG > >> > Hi, Matthias Thanks for your reply. > Although it is quite clear what the patch does, could you write one > sentence to explain what it does. Maybe explain even which effect it > has, which error get fixed etc. Ok, I will do that. > As we are getting public available boards now, we should take more care > about fixes. If you have a fix for a commit introduced in an earlier > version of linux and it should be fixed for this version as well (e.g. > v4.6 does have the feature but it does not work correctly) then please > add these two lines before your Signed-off-by: > Fixes: <commit-hash> ("<commit subject line>") > Cc: stable@vger.kernel.org # v4.6+ > > Where v4.6+ stands for the oldest version where this should get fixed. > Ok, but the patch hasn't been merged into v4.8 (just in drm-next [1] and linux-next [2]), how can I mark that? [1] https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=7216436420414144646f5d8343d061355fd23483 [2] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7216436420414144646f5d8343d061355fd23483 > Thanks a lot, > Matthias > > >> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com> > >> --- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > >> index df33b3c..aa5f20f 100644 > >> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > >> @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, > >> unsigned int bpc) > >> { > >> writel(w << 16 | h, comp->regs + DISP_OD_SIZE); > >> - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); > >> + writel(OD_RELAYMODE, comp->regs + OD_CFG); > >> mtk_dither_set(comp, bpc, DISP_OD_CFG); > >> } > >> > > > > -- Bibby ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/mediatek: fix a typo 2016-09-30 3:11 ` Bibby Hsieh @ 2016-10-03 8:46 ` Matthias Brugger 0 siblings, 0 replies; 5+ messages in thread From: Matthias Brugger @ 2016-10-03 8:46 UTC (permalink / raw) To: Bibby Hsieh Cc: CK Hu, David Airlie, Daniel Vetter, dri-devel, linux-mediatek, Yingjoe Chen, Cawa Cheng, Daniel Kurtz, Philipp Zabel, YT Shen, Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel, Sascha Hauer On 30/09/16 05:11, Bibby Hsieh wrote: > On Thu, 2016-09-29 at 10:46 +0200, Matthias Brugger wrote: >> >> On 29/09/16 06:01, CK Hu wrote: >>> Acked-by: CK Hu <ck.hu@mediatek.com> >>> >>> On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote: >>>> Fix the typo: OD_RELAYMODE->OD_CFG >>>> >> > > Hi, Matthias > Thanks for your reply. > >> Although it is quite clear what the patch does, could you write one >> sentence to explain what it does. Maybe explain even which effect it >> has, which error get fixed etc. > > Ok, I will do that. > >> As we are getting public available boards now, we should take more care >> about fixes. If you have a fix for a commit introduced in an earlier >> version of linux and it should be fixed for this version as well (e.g. >> v4.6 does have the feature but it does not work correctly) then please >> add these two lines before your Signed-off-by: >> Fixes: <commit-hash> ("<commit subject line>") >> Cc: stable@vger.kernel.org # v4.6+ >> >> Where v4.6+ stands for the oldest version where this should get fixed. >> > > Ok, but the patch hasn't been merged into v4.8 (just in drm-next [1] and > linux-next [2]), how can I mark that? > If the commit get's into v4.9 then make sure that this patch get's merged into the fixes for v4.9 by the corresponding maintainer. Regards, Matthias > [1] > https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=7216436420414144646f5d8343d061355fd23483 > [2] > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7216436420414144646f5d8343d061355fd23483 > > >> Thanks a lot, >> Matthias >> >>>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com> >>>> --- >>>> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> index df33b3c..aa5f20f 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, >>>> unsigned int bpc) >>>> { >>>> writel(w << 16 | h, comp->regs + DISP_OD_SIZE); >>>> - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); >>>> + writel(OD_RELAYMODE, comp->regs + OD_CFG); >>>> mtk_dither_set(comp, bpc, DISP_OD_CFG); >>>> } >>>> >>> >>> > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-03 8:46 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-29 3:22 [PATCH] drm/mediatek: fix a typo Bibby Hsieh 2016-09-29 4:01 ` CK Hu 2016-09-29 8:46 ` Matthias Brugger 2016-09-30 3:11 ` Bibby Hsieh 2016-10-03 8:46 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox