Re: [PATCH 1/2] arm: dts: mt7623: fix mmc interrupt assignment

Re: [PATCH 1/2] arm: dts: mt7623: fix mmc interrupt assignment

[Sean Wang]

On Tue, 2017-08-01 at 15:40 +0200, Matthias Brugger wrote:
> The mmc1 interrupt should be connected to GIC_SPI 40,
> this patch fixes this.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/mt7623.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index 4ae0ab07e053..2a877ed8ff23 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -648,7 +648,7 @@
>  		compatible = "mediatek,mt7623-mmc",
>  			     "mediatek,mt8135-mmc";
>  		reg = <0 0x11240000 0 0x1000>;
> -		interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_LOW>;
>  		clocks = <&pericfg CLK_PERI_MSDC30_1>,
>  			 <&topckgen CLK_TOP_MSDC30_1_SEL>;
>  		clock-names = "source", "hclk";


Hi, Matthias

many thanks!

Acked-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

	Sean

Re: [PATCH 2/2] arm: dts: mt7623: Add SD-card to bananapi-r2

[Sean Wang]

On Tue, 2017-08-01 at 15:40 +0200, Matthias Brugger wrote:
> The bananapi-r2 board has an SD-card controller, enable
> the device in the devicetree.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 9f3e6ddd545f..d457544c3a1d 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -179,6 +179,19 @@
>  	status = "okay";
>  };
>  
> +&mmc1 {
> +	pinctrl-names = "default", "state_uhs";
> +	pinctrl-0 = <&mmc1_pins_default>;
> +	pinctrl-1 = <&mmc1_pins_uhs>;
> +	status = "okay";
> +	bus-width = <4>;
> +	max-frequency = <50000000>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&pio 261 0>;
> +	vmmc-supply = <&mt6323_vmch_reg>;
> +	vqmmc-supply = <&mt6323_vmc_reg>;
> +};
> +
>  &pio {
>  	cir_pins_a:cir@0 {
>  		pins_cir {

I can base the patch to fixup and add something in the next version 

such as

1) to add property with extra wp-gpios

2) to correct power source from mt6323_vio18_reg instead of
mt6323_vmc_reg based on the schematic

3) to enable mmc0 that is used as emmc


&mmc0 {
        pinctrl-names = "default", "state_uhs";
        pinctrl-0 = <&mmc0_pins_default>;
        pinctrl-1 = <&mmc0_pins_uhs>;
        status = "okay";
        bus-width = <8>;
        max-frequency = <50000000>;
        cap-mmc-highspeed;
        vmmc-supply = <&mt6323_vemc3v3_reg>;
        vqmmc-supply = <&mt6323_vio18_reg>;
        non-removable;
};


&mmc1 {
        pinctrl-names = "default", "state_uhs";
        pinctrl-0 = <&mmc1_pins_default>;
        pinctrl-1 = <&mmc1_pins_uhs>;
        status = "okay";
        bus-width = <4>;
        max-frequency = <50000000>;
        cap-sd-highspeed;
        cd-gpios = <&pio 261 0>;
        wp-gpios = <&pio 29 0>;
        vmmc-supply = <&mt6323_vmch_reg>;
        vqmmc-supply = <&mt6323_vio18_reg>;
};


those upper nodes could make sdhc sd card/emmc workable