* [bug report] pinctrl: mediatek: add pinctrl driver for MT7622 SoC
@ 2018-01-09 9:55 Dan Carpenter
2018-01-09 14:13 ` Sean Wang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-01-09 9:55 UTC (permalink / raw)
To: sean.wang-NuS5LvNUpcJWk0Htik3J/w
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hello Sean Wang,
The patch d6ed93551320: "pinctrl: mediatek: add pinctrl driver for
MT7622 SoC" from Dec 12, 2017, leads to the following static checker
warning:
drivers/pinctrl/mediatek/pinctrl-mt7622.c:1419 mtk_gpio_get()
error: uninitialized symbol 'value'.
drivers/pinctrl/mediatek/pinctrl-mt7622.c
1412 static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
1413 {
1414 struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
1415 int value;
1416
1417 mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
^^^^^^^^^^^^^^^^
No error handling.
1418
1419 return !!value;
1420 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] pinctrl: mediatek: add pinctrl driver for MT7622 SoC
2018-01-09 9:55 [bug report] pinctrl: mediatek: add pinctrl driver for MT7622 SoC Dan Carpenter
@ 2018-01-09 14:13 ` Sean Wang
0 siblings, 0 replies; 2+ messages in thread
From: Sean Wang @ 2018-01-09 14:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, 2018-01-09 at 12:55 +0300, Dan Carpenter wrote:
> Hello Sean Wang,
>
> The patch d6ed93551320: "pinctrl: mediatek: add pinctrl driver for
> MT7622 SoC" from Dec 12, 2017, leads to the following static checker
> warning:
>
> drivers/pinctrl/mediatek/pinctrl-mt7622.c:1419 mtk_gpio_get()
> error: uninitialized symbol 'value'.
>
> drivers/pinctrl/mediatek/pinctrl-mt7622.c
> 1412 static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
> 1413 {
> 1414 struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
> 1415 int value;
> 1416
> 1417 mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
> ^^^^^^^^^^^^^^^^
> No error handling.
>
Nice catch, Will fix it soon.
Sean
> 1418
> 1419 return !!value;
> 1420 }
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 9:55 [bug report] pinctrl: mediatek: add pinctrl driver for MT7622 SoC Dan Carpenter
2018-01-09 14:13 ` Sean Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox