porting 6797 to upstream kernel

porting 6797 to upstream kernel

[Saber Rezvani]

Hi,


My friend and I have decided to port Mediatek 6797 board pinctrl to 
upstream kernel (regarding to our talked to Matthias). As our discussion 
with Matthias, we are poring the driver based on 7622 pinctrl style in 
upstream kernel.

Right now we have totally understood the 6797 and 7622 pinctrl drivers, 
but we do not know where we can find the data of the following  data 
structures:


     *) struct mtk_pin_field_calc

     *) pinctrl_pin_desc


As our search on BSP repository, branch name: helio-x20 we figured out 
there are some file as following:

drivers/misc/mediatek/gpio/mt6797/gpio_cfg.h

arch/arm64/boot/dts/include/dt-bindings/pinctrl/mt6797-pinfunc.h


But we have not yet known whether these data is useful or not, and if 
Yes, how we can transport them in 7622 styles.



Best regards,

Saber




_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: porting 6797 to upstream kernel

[Sean Wang]

Hi, Saber

On Fri, 2018-08-17 at 20:12 +0430, Saber Rezvani wrote:
> Hi,
> 
> 
> My friend and I have decided to port Mediatek 6797 board pinctrl to 
> upstream kernel (regarding to our talked to Matthias). As our discussion 
> with Matthias, we are poring the driver based on 7622 pinctrl style in 
> upstream kernel.
> 

It's really nice to see more people have interests on mediatek soc.

It is actually feasible that mt6797 ported to mt7622 pinctrl style
driver. In fact, mt7622 driver should be generic enough to allow any
mediatek soc to be ported to with the driver style even though a certain
soc owns the irregular register layout.

> Right now we have totally understood the 6797 and 7622 pinctrl drivers, 
> but we do not know where we can find the data of the following  data 
> structures:
> 
> 
>      *) struct mtk_pin_field_calc

if you have hardware datasheet, it'd be easy to do this part. otherwise,
being interpreted from vendor driver is a little annoy but doable, I
think.

the structure needs to be filled by the information register field per
pin has about where the register offset it is located at, and
information required to identify the same field for the neighbor pin.
 
>      *) pinctrl_pin_desc
> 
> 

I used to fill the structure with pin number and the name of ballout,

> As our search on BSP repository, branch name: helio-x20 we figured out 
> there are some file as following:
> 
> drivers/misc/mediatek/gpio/mt6797/gpio_cfg.h
> 

I am not actually sure what content it has, but I guess it the result
generated by a vendor tool.

> arch/arm64/boot/dts/include/dt-bindings/pinctrl/mt6797-pinfunc.h

it provides pin and its mode the pin can support and can be switched to.

it would be useful and good to develop pinctrl_pin_desc and

and the mode mt6797_xxx_funcs would imply as [1] have that will be
registered into the generic core lay.

[1] for example with mt7622 pinctrl

https://elixir.bootlin.com/linux/v4.18-rc8/source/drivers/pinctrl/mediatek/pinctrl-mt7622.c#L437

> 
> But we have not yet known whether these data is useful or not, and if 
> Yes, how we can transport them in 7622 styles.
> 
> 
> 
> Best regards,
> 
> Saber
> 
> 
>