* [PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler
@ 2018-12-07 3:52 YueHaibing
2018-12-07 5:17 ` Chunfeng Yun
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-12-07 3:52 UTC (permalink / raw)
To: Chunfeng Yun, Greg Kroah-Hartman, Matthias Brugger
Cc: linux-mediatek, kernel-janitors, linux-usb, YueHaibing,
linux-arm-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/usb/mtu3/mtu3_qmu.c: In function 'qmu_tx_zlp_error_handler':
drivers/usb/mtu3/mtu3_qmu.c:385:22: warning:
variable 'req' set but not used [-Wunused-but-set-variable]
It seems dbginfo original intention is print 'req' other than 'mreq'
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/usb/mtu3/mtu3_qmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
index 73ac042..09f19f7 100644
--- a/drivers/usb/mtu3/mtu3_qmu.c
+++ b/drivers/usb/mtu3/mtu3_qmu.c
@@ -402,7 +402,7 @@ static void qmu_tx_zlp_error_handler(struct mtu3 *mtu, u8 epnum)
return;
}
- dev_dbg(mtu->dev, "%s send ZLP for req=%p\n", __func__, mreq);
+ dev_dbg(mtu->dev, "%s send ZLP for req=%p\n", __func__, req);
mtu3_clrbits(mbase, MU3D_EP_TXCR0(mep->epnum), TX_DMAREQEN);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler
2018-12-07 3:52 [PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler YueHaibing
@ 2018-12-07 5:17 ` Chunfeng Yun
0 siblings, 0 replies; 2+ messages in thread
From: Chunfeng Yun @ 2018-12-07 5:17 UTC (permalink / raw)
To: YueHaibing
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-mediatek,
Matthias Brugger, linux-arm-kernel
Hi Haibing,
On Fri, 2018-12-07 at 03:52 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/mtu3/mtu3_qmu.c: In function 'qmu_tx_zlp_error_handler':
> drivers/usb/mtu3/mtu3_qmu.c:385:22: warning:
> variable 'req' set but not used [-Wunused-but-set-variable]
>
> It seems dbginfo original intention is print 'req' other than 'mreq'
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/mtu3/mtu3_qmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
> index 73ac042..09f19f7 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.c
> +++ b/drivers/usb/mtu3/mtu3_qmu.c
> @@ -402,7 +402,7 @@ static void qmu_tx_zlp_error_handler(struct mtu3 *mtu, u8 epnum)
> return;
> }
>
> - dev_dbg(mtu->dev, "%s send ZLP for req=%p\n", __func__, mreq);
> + dev_dbg(mtu->dev, "%s send ZLP for req=%p\n", __func__, req);
>
> mtu3_clrbits(mbase, MU3D_EP_TXCR0(mep->epnum), TX_DMAREQEN);
>
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thanks a lot
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-07 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-07 3:52 [PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler YueHaibing
2018-12-07 5:17 ` Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox