From: Eason Yen <eason.yen@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org, jiaxin.yu@mediatek.com,
chipeng.chang@mediatek.com
Subject: Re: [PATCH] ASoC: mediatek: common: refine mtk_afe_fe_hw_params
Date: Fri, 15 Nov 2019 13:33:22 +0800 [thread overview]
Message-ID: <1573796002.14232.14.camel@mtkswgap22> (raw)
In-Reply-To: <20191112173409.GI5195@sirena.co.uk>
Hi Mark,
On Tue, 2019-11-12 at 17:34 +0000, Mark Brown wrote:
> On Tue, Nov 12, 2019 at 12:22:18PM +0800, Eason Yen wrote:
...
>
> It'd be better to split these two into separate patches, they're two
> separate things. Ideally the refactoring should just be simple code
> motion. Right now the patch is a bit difficult to follow.
>
Ok, I will separate this patch soon.
> > static int mtk_regmap_update_bits(struct regmap *map, int reg,
> > - unsigned int mask,
> > - unsigned int val, int shift)
> > + unsigned int mask,
> > + unsigned int val, int shift)
> > {
> > if (reg < 0 || WARN_ON_ONCE(shift < 0))
> > return 0;
>
> This is an unrelated indentation change?
Yes, it is an alignment that to match open parenthesis.
>
> > + dev_info(afe->dev, "%s(), %s, ch %d, rate %d, fmt %d, dma_addr %pad, dma_area %p, dma_bytes 0x%zx\n",
> > + __func__, memif->data->name,
> > + channels, rate, format,
> > + &substream->runtime->dma_addr,
> > + substream->runtime->dma_area,
> > + substream->runtime->dma_bytes);
>
> This is going to get noisy, dev_dbg at most please.
Ok, thanks for your suggestion.
Regards,
Eason
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-11-15 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 4:22 [PATCH v1] ASoC: mediatek: common: refine mtk_afe_fe_hw_params Eason Yen
2019-11-12 4:22 ` [PATCH] " Eason Yen
2019-11-12 17:34 ` Mark Brown
2019-11-15 5:33 ` Eason Yen [this message]
2019-11-12 11:56 ` [PATCH v1] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573796002.14232.14.camel@mtkswgap22 \
--to=eason.yen@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chipeng.chang@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox