From: Mark Brown <broonie@kernel.org>
To: Eason Yen <eason.yen@mediatek.com>
Cc: matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org, jiaxin.yu@mediatek.com,
chipeng.chang@mediatek.com
Subject: Re: [PATCH] ASoC: mediatek: common: refine mtk_afe_fe_hw_params
Date: Tue, 12 Nov 2019 17:34:09 +0000 [thread overview]
Message-ID: <20191112173409.GI5195@sirena.co.uk> (raw)
In-Reply-To: <1573532538-30602-2-git-send-email-eason.yen@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 1235 bytes --]
On Tue, Nov 12, 2019 at 12:22:18PM +0800, Eason Yen wrote:
> 1. Add the following function to refine mtk_afe_fe_hw_params
> - mtk_memif_set_enable
> - mtk_memif_set_disable
> - mtk_memif_set_addr
> - mtk_memif_set_channel
> - mtk_memif_set_rate
> - mtk_memif_set_rate_substream
> - mtk_memif_set_format
> - mtk_memif_set_pbuf_size
> 2. extend mtk_base_memif_data struct for new platform(mt6779)
It'd be better to split these two into separate patches, they're two
separate things. Ideally the refactoring should just be simple code
motion. Right now the patch is a bit difficult to follow.
> static int mtk_regmap_update_bits(struct regmap *map, int reg,
> - unsigned int mask,
> - unsigned int val, int shift)
> + unsigned int mask,
> + unsigned int val, int shift)
> {
> if (reg < 0 || WARN_ON_ONCE(shift < 0))
> return 0;
This is an unrelated indentation change?
> + dev_info(afe->dev, "%s(), %s, ch %d, rate %d, fmt %d, dma_addr %pad, dma_area %p, dma_bytes 0x%zx\n",
> + __func__, memif->data->name,
> + channels, rate, format,
> + &substream->runtime->dma_addr,
> + substream->runtime->dma_area,
> + substream->runtime->dma_bytes);
This is going to get noisy, dev_dbg at most please.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-11-12 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 4:22 [PATCH v1] ASoC: mediatek: common: refine mtk_afe_fe_hw_params Eason Yen
2019-11-12 4:22 ` [PATCH] " Eason Yen
2019-11-12 17:34 ` Mark Brown [this message]
2019-11-15 5:33 ` Eason Yen
2019-11-12 11:56 ` [PATCH v1] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112173409.GI5195@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=chipeng.chang@mediatek.com \
--cc=eason.yen@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox