Re: [PATCH 1/2] mt76: mt7921u: enable HW beacon filter

[<sean.wang@mediatek.com>]

From: Sean Wang <sean.wang@mediatek.com>

>>On 16.06.22 03:10, sean.wang@mediatek.com wrote:
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> HW beacon filter and HW connection monitor can be supported on MT7921U
>> as well so we enable them to be consistent with MT7921[E,S].
>>
>> Tested-by: Deren Wu <deren.wu@mediatek.com>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> ---
>>   drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> index acf6567368b7..d803a7dd5f83 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> @@ -677,8 +677,7 @@ static void mt7921_bss_info_changed(struct ieee80211_hw *hw,
>>	if (changed & BSS_CHANGED_ASSOC) {
>>		mt7921_mcu_sta_update(dev, NULL, vif, true,
>>				      MT76_STA_INFO_STATE_ASSOC);
>> -		if (dev->pm.enable)
>> -			mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
>> +		mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
>To me it looks like patch description and code change don't really match. Could you please explain why you change it so that the beacon filter is enabled even if PM isn't?

dev->pm.enable is supposed to control runtime pm only and not related to hw beacon filter.

MT7921U still cannot support runtime pm as eafe031fd664 ("mt76: mt7921: disable runtime pm for usb") said.
but it doesn't only disable runtime pm but also would block the hw beacon filter to be enabled on MT7921U.
So here I correct dev->pm.enable usage to allow hw beacon filter enabled for MT7921U.

>
>- Felix
>