* Re: [PATCH 1/2] mt76: mt7921u: enable HW beacon filter
[not found] <092a2631-4e91-203e-9199-96fd3c689afa@nbd.name--annotate>
@ 2022-06-17 22:37 ` sean.wang
0 siblings, 0 replies; 3+ messages in thread
From: sean.wang @ 2022-06-17 22:37 UTC (permalink / raw)
To: nbd
Cc: lorenzo.bianconi, sean.wang, Soul.Huang, YN.Chen, Leon.Yen,
Eric-SY.Chang, Mark-YW.Chen, Deren.Wu, km.lin, jenhao.yang,
robin.chiu, Eddie.Chen, ch.yeh, posh.sun, ted.huang, Eric.Liang,
Stella.Chang, Tom.Chou, steve.lee, jsiuda, frankgor, jemele,
abhishekpandit, shawnku, linux-wireless, linux-mediatek
From: Sean Wang <sean.wang@mediatek.com>
>>On 16.06.22 03:10, sean.wang@mediatek.com wrote:
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> HW beacon filter and HW connection monitor can be supported on MT7921U
>> as well so we enable them to be consistent with MT7921[E,S].
>>
>> Tested-by: Deren Wu <deren.wu@mediatek.com>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> index acf6567368b7..d803a7dd5f83 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
>> @@ -677,8 +677,7 @@ static void mt7921_bss_info_changed(struct ieee80211_hw *hw,
>> if (changed & BSS_CHANGED_ASSOC) {
>> mt7921_mcu_sta_update(dev, NULL, vif, true,
>> MT76_STA_INFO_STATE_ASSOC);
>> - if (dev->pm.enable)
>> - mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
>> + mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
>To me it looks like patch description and code change don't really match. Could you please explain why you change it so that the beacon filter is enabled even if PM isn't?
dev->pm.enable is supposed to control runtime pm only and not related to hw beacon filter.
MT7921U still cannot support runtime pm as eafe031fd664 ("mt76: mt7921: disable runtime pm for usb") said.
but it doesn't only disable runtime pm but also would block the hw beacon filter to be enabled on MT7921U.
So here I correct dev->pm.enable usage to allow hw beacon filter enabled for MT7921U.
>
>- Felix
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] mt76: mt7921u: enable HW beacon filter
@ 2022-06-16 1:10 sean.wang
2022-06-17 10:18 ` Felix Fietkau
0 siblings, 1 reply; 3+ messages in thread
From: sean.wang @ 2022-06-16 1:10 UTC (permalink / raw)
To: nbd, lorenzo.bianconi
Cc: sean.wang, Soul.Huang, YN.Chen, Leon.Yen, Eric-SY.Chang, Deren.Wu,
km.lin, jenhao.yang, robin.chiu, Eddie.Chen, ch.yeh, posh.sun,
ted.huang, Eric.Liang, Stella.Chang, Tom.Chou, steve.lee, jsiuda,
frankgor, jemele, abhishekpandit, shawnku, linux-wireless,
linux-mediatek
From: Sean Wang <sean.wang@mediatek.com>
HW beacon filter and HW connection monitor can be supported on MT7921U
as well so we enable them to be consistent with MT7921[E,S].
Tested-by: Deren Wu <deren.wu@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
index acf6567368b7..d803a7dd5f83 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
@@ -677,8 +677,7 @@ static void mt7921_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_ASSOC) {
mt7921_mcu_sta_update(dev, NULL, vif, true,
MT76_STA_INFO_STATE_ASSOC);
- if (dev->pm.enable)
- mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
+ mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
}
if (changed & BSS_CHANGED_ARP_FILTER) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] mt76: mt7921u: enable HW beacon filter
2022-06-16 1:10 sean.wang
@ 2022-06-17 10:18 ` Felix Fietkau
0 siblings, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2022-06-17 10:18 UTC (permalink / raw)
To: sean.wang, lorenzo.bianconi
Cc: Soul.Huang, YN.Chen, Leon.Yen, Eric-SY.Chang, Deren.Wu, km.lin,
jenhao.yang, robin.chiu, Eddie.Chen, ch.yeh, posh.sun, ted.huang,
Eric.Liang, Stella.Chang, Tom.Chou, steve.lee, jsiuda, frankgor,
jemele, abhishekpandit, shawnku, linux-wireless, linux-mediatek
On 16.06.22 03:10, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> HW beacon filter and HW connection monitor can be supported on MT7921U
> as well so we enable them to be consistent with MT7921[E,S].
>
> Tested-by: Deren Wu <deren.wu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> index acf6567368b7..d803a7dd5f83 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> @@ -677,8 +677,7 @@ static void mt7921_bss_info_changed(struct ieee80211_hw *hw,
> if (changed & BSS_CHANGED_ASSOC) {
> mt7921_mcu_sta_update(dev, NULL, vif, true,
> MT76_STA_INFO_STATE_ASSOC);
> - if (dev->pm.enable)
> - mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
> + mt7921_mcu_set_beacon_filter(dev, vif, info->assoc);
To me it looks like patch description and code change don't really
match. Could you please explain why you change it so that the beacon
filter is enabled even if PM isn't?
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-17 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <092a2631-4e91-203e-9199-96fd3c689afa@nbd.name--annotate>
2022-06-17 22:37 ` [PATCH 1/2] mt76: mt7921u: enable HW beacon filter sean.wang
2022-06-16 1:10 sean.wang
2022-06-17 10:18 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox