Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
@ 2022-10-24 23:06 Nícolas F. R. A. Prado
  2022-10-26  1:09 ` Rob Herring
  2022-10-26 19:04 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-24 23:06 UTC (permalink / raw)
  To: Mark Brown
  Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado,
	Jiaxin Yu, Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek

sound-dai is a standard property whose type is already set to
phandle-array by sound-dai.yaml, so there's no need to set it (and
wrongly so for headset-codec) in this binding. What should be set
however is the maximum number of items, which for headset-codec should
be 1.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 .../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
index 478be7e3fa29..c6e614c1c30b 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
@@ -34,7 +34,7 @@ properties:
 
     properties:
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        maxItems: 1
     required:
       - sound-dai
 
@@ -48,7 +48,6 @@ properties:
         maxItems: 2
         items:
           maxItems: 1
-        $ref: /schemas/types.yaml#/definitions/phandle-array
     required:
       - sound-dai
 
-- 
2.38.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
  2022-10-24 23:06 [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai Nícolas F. R. A. Prado
@ 2022-10-26  1:09 ` Rob Herring
  2022-10-26 19:04 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-10-26  1:09 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: Mark Brown, alsa-devel, kernel, Rob Herring, Jiaxin Yu,
	Liam Girdwood, devicetree, linux-kernel, Matthias Brugger,
	Shane Chien, linux-mediatek, linux-arm-kernel,
	AngeloGioacchino Del Regno, Krzysztof Kozlowski

On Mon, 24 Oct 2022 19:06:57 -0400, Nícolas F. R. A. Prado wrote:
> sound-dai is a standard property whose type is already set to
> phandle-array by sound-dai.yaml, so there's no need to set it (and
> wrongly so for headset-codec) in this binding. What should be set
> however is the maximum number of items, which for headset-codec should
> be 1.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> ---
> 
>  .../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
  2022-10-24 23:06 [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai Nícolas F. R. A. Prado
  2022-10-26  1:09 ` Rob Herring
@ 2022-10-26 19:04 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-10-26 19:04 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: AngeloGioacchino Del Regno, linux-arm-kernel, kernel, alsa-devel,
	Matthias Brugger, linux-mediatek, Krzysztof Kozlowski, devicetree,
	Rob Herring, linux-kernel, Jiaxin Yu, Shane Chien, Liam Girdwood

On Mon, 24 Oct 2022 19:06:57 -0400, Nícolas F. R. A. Prado wrote:
> sound-dai is a standard property whose type is already set to
> phandle-array by sound-dai.yaml, so there's no need to set it (and
> wrongly so for headset-codec) in this binding. What should be set
> however is the maximum number of items, which for headset-codec should
> be 1.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
      commit: 555e6f573a0a08b66b9543a0e098c5d6adf8e8af

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-26 19:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 23:06 [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai Nícolas F. R. A. Prado
2022-10-26  1:09 ` Rob Herring
2022-10-26 19:04 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox