* [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface
@ 2025-04-16 10:26 Russell King (Oracle)
2025-04-16 12:28 ` Andrew Lunn
2025-04-18 2:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2025-04-16 10:26 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit
Cc: Alexandre Torgue, Andrew Lunn, AngeloGioacchino Del Regno,
David S. Miller, Eric Dumazet, Jakub Kicinski, linux-arm-kernel,
linux-mediatek, linux-stm32, Matthias Brugger, Maxime Coquelin,
netdev, Paolo Abeni
Mediatek doesn't make use of mac_interface, and none of the in-tree
DT files use the mac-mode property. Therefore, mac_interface already
follows phy_interface. Remove this unnecessary assignment.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
index d178d5ddc7c7..39421d6a34e4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
@@ -581,7 +581,6 @@ static int mediatek_dwmac_common_data(struct platform_device *pdev,
int i;
priv_plat->phy_mode = plat->phy_interface;
- plat->mac_interface = priv_plat->phy_mode;
if (priv_plat->mac_wol)
plat->flags &= ~STMMAC_FLAG_USE_PHY_WOL;
else
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface
2025-04-16 10:26 [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface Russell King (Oracle)
@ 2025-04-16 12:28 ` Andrew Lunn
2025-04-18 2:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2025-04-16 12:28 UTC (permalink / raw)
To: Russell King (Oracle)
Cc: Heiner Kallweit, Alexandre Torgue, Andrew Lunn,
AngeloGioacchino Del Regno, David S. Miller, Eric Dumazet,
Jakub Kicinski, linux-arm-kernel, linux-mediatek, linux-stm32,
Matthias Brugger, Maxime Coquelin, netdev, Paolo Abeni
On Wed, Apr 16, 2025 at 11:26:47AM +0100, Russell King (Oracle) wrote:
> Mediatek doesn't make use of mac_interface, and none of the in-tree
> DT files use the mac-mode property. Therefore, mac_interface already
> follows phy_interface. Remove this unnecessary assignment.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface
2025-04-16 10:26 [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface Russell King (Oracle)
2025-04-16 12:28 ` Andrew Lunn
@ 2025-04-18 2:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-18 2:10 UTC (permalink / raw)
To: Russell King
Cc: andrew, hkallweit1, alexandre.torgue, andrew+netdev,
angelogioacchino.delregno, davem, edumazet, kuba,
linux-arm-kernel, linux-mediatek, linux-stm32, matthias.bgg,
mcoquelin.stm32, netdev, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Apr 2025 11:26:47 +0100 you wrote:
> Mediatek doesn't make use of mac_interface, and none of the in-tree
> DT files use the mac-mode property. Therefore, mac_interface already
> follows phy_interface. Remove this unnecessary assignment.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: stmmac: mediatek: stop initialising plat->mac_interface
https://git.kernel.org/netdev/net-next/c/01be295b485a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-18 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 10:26 [PATCH net-next] net: stmmac: mediatek: stop initialising plat->mac_interface Russell King (Oracle)
2025-04-16 12:28 ` Andrew Lunn
2025-04-18 2:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox