public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: jie.qiu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: re: drm/mediatek: Add DPI sub driver
Date: Thu, 12 May 2016 13:26:23 +0300	[thread overview]
Message-ID: <20160512102622.GA14068@mwanda> (raw)

Hello Jie Qiu,

This is a semi-automatic email about new static checker warnings.

The patch 9e629c17aa8d: "drm/mediatek: Add DPI sub driver" from Jan 
4, 2016, leads to the following Smatch complaint:

drivers/gpu/drm/mediatek/mtk_dpi.c:436 mtk_dpi_set_display_mode()
	 error: we previously assumed 'dpi' could be null (see line 435)

drivers/gpu/drm/mediatek/mtk_dpi.c
   434	
   435		if (!dpi) {
                    ^^^^
Check.

   436			dev_err(dpi->dev, "invalid argument\n");
                                ^^^^^^^^^
Deref.  Can dpi even be NULL, btw?

   437			return -EINVAL;
   438		}

regards,
dan carpenter

                 reply	other threads:[~2016-05-12 10:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512102622.GA14068@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=jie.qiu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox