From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: RogerCC Lin <rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
steven.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH v5 0/2] mtd: nand: fix writing incorrect ECC parity data in OOB region
Date: Mon, 19 Sep 2016 11:47:58 +0200 [thread overview]
Message-ID: <20160919114758.37ec6606@bbrezillon> (raw)
In-Reply-To: <1474253606-9965-1-git-send-email-rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Mon, 19 Sep 2016 10:53:24 +0800
RogerCC Lin <rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> From: RogerCC Lin <rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> This series fix chances to write incorrect ECC data which may cause uncorrectable ECC error when reading.
Applied (I'll send a PR to Brian).
Thanks,
Boris
>
> change since v4:
> - use (i / 4) instead of (i >> 2) to make code more clear.
>
> changes since v3:
> - use macro for function arguments.
>
> changes since v2:
> - use macro for shift operation.
>
> changes since v1:
> - separate patches into 2.
> - use shift operator with byte access to avoid endianness conversion problems.
> - follow linux coding style.
>
> The patch passed the test of UBIFS file-system read/write on Mediatek's RFB. The tested driver is checked-out from LEDE OpenWRT project's upstream driver, which is pretty much same as nand/next branch upstream driver(git clone https://git.lede-project.org/source.git).
>
>
> RogerCC Lin (2):
> mtd: nand: fix generating over-boundary ECC data when writing
> mtd: nand: fix chances to create incomplete ECC data when writing
>
> drivers/mtd/nand/mtk_ecc.c | 12 ++++++++----
> drivers/mtd/nand/mtk_nand.c | 7 +++++--
> 2 files changed, 13 insertions(+), 6 deletions(-)
>
prev parent reply other threads:[~2016-09-19 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 2:53 [PATCH v5 0/2] mtd: nand: fix writing incorrect ECC parity data in OOB region RogerCC Lin
[not found] ` <1474253606-9965-1-git-send-email-rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-09-19 2:53 ` [PATCH v5 1/2] mtd: nand: fix generating over-boundary ECC data when writing RogerCC Lin
2016-09-19 2:53 ` [PATCH v5 2/2] mtd: nand: fix chances to create incomplete " RogerCC Lin
2016-09-19 9:47 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919114758.37ec6606@bbrezillon \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=steven.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox