* [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers
[not found] <1502454794-28558-1-git-send-email-cakturk@gmail.com>
@ 2017-08-11 12:32 ` Cihangir Akturk
2017-08-11 13:01 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Cihangir Akturk @ 2017-08-11 12:32 UTC (permalink / raw)
Cc: daniel, David Airlie, linux-kernel, dri-devel, Cihangir Akturk,
Matthias Brugger, Philipp Zabel, CK Hu, linux-mediatek,
linux-arm-kernel
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
and drm_*_unreference() helpers.
drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to
use the new APIs.
Generated by: scripts/coccinelle/api/drm-get-put.cocci
Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_drm_fb.c | 4 ++--
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
index d4246c9..0d8d506 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
@@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct drm_framebuffer *fb)
drm_framebuffer_cleanup(fb);
- drm_gem_object_unreference_unlocked(mtk_fb->gem_obj);
+ drm_gem_object_put_unlocked(mtk_fb->gem_obj);
kfree(mtk_fb);
}
@@ -160,6 +160,6 @@ struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev,
return &mtk_fb->base;
unreference:
- drm_gem_object_unreference_unlocked(gem);
+ drm_gem_object_put_unlocked(gem);
return ERR_PTR(ret);
}
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 8ec963f..f595ac8 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file *file_priv, struct drm_device *dev,
goto err_handle_create;
/* drop reference from allocate - handle holds it now. */
- drm_gem_object_unreference_unlocked(&mtk_gem->base);
+ drm_gem_object_put_unlocked(&mtk_gem->base);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers
2017-08-11 12:32 ` [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers Cihangir Akturk
@ 2017-08-11 13:01 ` Philipp Zabel
2017-08-11 16:04 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Zabel @ 2017-08-11 13:01 UTC (permalink / raw)
To: Cihangir Akturk
Cc: CK Hu, daniel, linux-kernel, dri-devel, David Airlie,
Matthias Brugger, linux-arm-kernel, linux-mediatek
On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote:
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
>
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.
>
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_fb.c | 4 ++--
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> index d4246c9..0d8d506 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct
> drm_framebuffer *fb)
>
> drm_framebuffer_cleanup(fb);
>
> - drm_gem_object_unreference_unlocked(mtk_fb->gem_obj);
> + drm_gem_object_put_unlocked(mtk_fb->gem_obj);
>
> kfree(mtk_fb);
> }
> @@ -160,6 +160,6 @@ struct drm_framebuffer
> *mtk_drm_mode_fb_create(struct drm_device *dev,
> return &mtk_fb->base;
>
> unreference:
> - drm_gem_object_unreference_unlocked(gem);
> + drm_gem_object_put_unlocked(gem);
> return ERR_PTR(ret);
> }
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 8ec963f..f595ac8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file
> *file_priv, struct drm_device *dev,
> goto err_handle_create;
>
> /* drop reference from allocate - handle holds it now. */
> - drm_gem_object_unreference_unlocked(&mtk_gem->base);
> + drm_gem_object_put_unlocked(&mtk_gem->base);
>
> return 0;
>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers
2017-08-11 13:01 ` Philipp Zabel
@ 2017-08-11 16:04 ` Sean Paul
0 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2017-08-11 16:04 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, dri-devel, Cihangir Akturk, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Fri, Aug 11, 2017 at 03:01:40PM +0200, Philipp Zabel wrote:
> On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote:
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> > and drm_*_unreference() helpers.
> >
> > drm_*_reference() and drm_*_unreference() functions are just
> > compatibility alias for drm_*_get() and drm_*_put() and should not be
> > used by new code. So convert all users of compatibility functions to
> > use the new APIs.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 4 ++--
> > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> > index d4246c9..0d8d506 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> > @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct
> > drm_framebuffer *fb)
> >
> > drm_framebuffer_cleanup(fb);
> >
> > - drm_gem_object_unreference_unlocked(mtk_fb->gem_obj);
> > + drm_gem_object_put_unlocked(mtk_fb->gem_obj);
> >
> > kfree(mtk_fb);
> > }
> > @@ -160,6 +160,6 @@ struct drm_framebuffer
> > *mtk_drm_mode_fb_create(struct drm_device *dev,
> > return &mtk_fb->base;
> >
> > unreference:
> > - drm_gem_object_unreference_unlocked(gem);
> > + drm_gem_object_put_unlocked(gem);
> > return ERR_PTR(ret);
> > }
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> > index 8ec963f..f595ac8 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> > @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file
> > *file_priv, struct drm_device *dev,
> > goto err_handle_create;
> >
> > /* drop reference from allocate - handle holds it now. */
> > - drm_gem_object_unreference_unlocked(&mtk_gem->base);
> > + drm_gem_object_put_unlocked(&mtk_gem->base);
> >
> > return 0;
> >
>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to drm-misc-next, thank you for the review!
Sean
>
> regards
> Philipp
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1502454794-28558-1-git-send-email-cakturk@gmail.com>
2017-08-11 12:32 ` [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers Cihangir Akturk
2017-08-11 13:01 ` Philipp Zabel
2017-08-11 16:04 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox