From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: stanley.chu@mediatek.com
Cc: linux-scsi@vger.kernel.org, wsd_upstream@mediatek.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
kuohong.wang@mediatek.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] scsi: Synchronize request queue PM status only on successful resume
Date: Thu, 3 Jan 2019 10:23:33 +0200 [thread overview]
Message-ID: <20190103082333.GL2469@lahna.fi.intel.com> (raw)
In-Reply-To: <1546498395-4184-3-git-send-email-stanley.chu@mediatek.com>
Hi,
On Thu, Jan 03, 2019 at 02:53:15PM +0800, stanley.chu@mediatek.com wrote:
> From: Stanley Chu <stanley.chu@mediatek.com>
>
> The commit 356fd2663cff ("scsi: Set request queue runtime PM status
> back to active on resume") fixed up the inconsistent RPM status between
> request queue and device. However changing request queue RPM status
> shall be done only on successful resume, otherwise status may be still
> inconsistent as below,
>
> Request queue: RPM_ACTIVE
> Device: RPM_SUSPENDED
>
> This ends up soft lockup because requests can be submitted to
> underlying devices but those devices and their required resource
> are not resumed.
It would be good to add some example of the soft lockup you are seeing
here.
> Fixes: 356fd2663cff ("scsi: Set request queue runtime PM status
> back to active on resume")
You don't need to wrap this.
The change itself looks fine.
next prev parent reply other threads:[~2019-01-03 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 6:53 [PATCH v2] scsi: Synchronize request queue PM status only on successful resume stanley.chu-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <1546498395-4184-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-01-03 6:53 ` [PATCH v2 0/1] " stanley.chu-NuS5LvNUpcJWk0Htik3J/w
2019-01-03 6:53 ` [PATCH v2 1/1] " stanley.chu-NuS5LvNUpcJWk0Htik3J/w
2019-01-03 8:23 ` Mika Westerberg [this message]
2019-01-03 9:06 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103082333.GL2469@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox