Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Milo Kim" <milo.kim@ti.com>,
	"Andrei Stefanescu" <andrei.stefanescu@microchip.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Brendan Higgins" <brendanhiggins@google.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	mikko.mutanen@fi.rohmeurope.com,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	linux-samsung-soc@vger.kernel.org,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Andy Gross" <agross@kernel.org>,
	markus.laine@fi.rohmeurope.com, linux-arm-msm@vger.kernel.org,
	"Borislav Petkov" <bp@suse.de>, "Petr Mladek" <pmladek@suse.com>,
	"Mikhail Zaslonko" <zaslonko@linux.ibm.com>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	mazziesaccount@gmail.com, "Gary Hook" <Gary.Hook@amd.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"David Gow" <davidgow@google.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Sangbeom Kim" <sbkim73@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, "Randy Dunlap" <rdunlap@infradead.org>,
	"Sebastian Reichel" <sre@kernel.org>,
	linux-kernel@vger.kernel.org, "Tal Gilboa" <talgi@mellanox.com>,
	"Changbin Du" <changbin.du@intel.com>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	patches@opensource.cirrus.com,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v6 06/10] regulator: use linear_ranges helper
Date: Tue, 24 Mar 2020 14:24:27 +0000	[thread overview]
Message-ID: <20200324142427.GF7039@sirena.org.uk> (raw)
In-Reply-To: <5522b2e03f77e1b7c93adf07b85747ea9ddfbf9b.1584977512.git.matti.vaittinen@fi.rohmeurope.com>


[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

On Tue, Mar 24, 2020 at 10:30:54AM +0200, Matti Vaittinen wrote:

>  
> -		if (!(min_uV <= linear_max_uV && max_uV >= range->min_uV))
> +		ret = linear_range_get_selector_high(range, min_uV, &sel,
> +						     &found);
> +		if (ret)
>  			continue;

Why are these going for _get_selector_high()?  Usually we try to choose
the lowest voltage we can.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2020-03-24 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  8:27 [PATCH v6 00/10] Support ROHM BD99954 charger IC Matti Vaittinen
2020-03-24  8:29 ` [PATCH v6 03/10] lib: add linear ranges helpers Matti Vaittinen
2020-03-24 14:16   ` Mark Brown
2020-03-27 19:34   ` Linus Walleij
2020-03-24  8:30 ` [PATCH v6 06/10] regulator: use linear_ranges helper Matti Vaittinen
2020-03-24 14:24   ` Mark Brown [this message]
2020-03-25  6:58     ` Vaittinen, Matti
2020-03-25 11:34       ` Mark Brown
2020-03-25 11:46         ` Vaittinen, Matti
2020-03-24 16:41   ` Charles Keepax
2020-03-24 16:48   ` Adam Thomson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324142427.GF7039@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Gary.Hook@amd.com \
    --cc=agross@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrei.stefanescu@microchip.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=bp@suse.de \
    --cc=brendanhiggins@google.com \
    --cc=changbin.du@intel.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=davidgow@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markus.laine@fi.rohmeurope.com \
    --cc=matthias.bgg@gmail.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=mikko.mutanen@fi.rohmeurope.com \
    --cc=milo.kim@ti.com \
    --cc=olteanv@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sbkim73@samsung.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sre@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=talgi@mellanox.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=uwe@kleine-koenig.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=wens@csie.org \
    --cc=yamada.masahiro@socionext.com \
    --cc=zaslonko@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox