From: Mark Brown <broonie@kernel.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"milo.kim@ti.com" <milo.kim@ti.com>,
"andrei.stefanescu@microchip.com"
<andrei.stefanescu@microchip.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"Gary.Hook@amd.com" <Gary.Hook@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"uwe@kleine-koenig.org" <uwe@kleine-koenig.org>,
"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
"vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"ardb@kernel.org" <ardb@kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"wens@csie.org" <wens@csie.org>,
"agross@kernel.org" <agross@kernel.org>,
"Laine, Markus" <Markus.Laine@fi.rohmeurope.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"bp@suse.de" <bp@suse.de>, "pmladek@suse.com" <pmladek@suse.com>,
"zaslonko@linux.ibm.com" <zaslonko@linux.ibm.com>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"brendanhiggins@google.com" <brendanhiggins@google.com>,
"rf@opensource.cirrus.com" <rf@opensource.cirrus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"sre@kernel.org" <sre@kernel.org>,
"davidgow@google.com" <davidgow@google.com>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
"sbkim73@samsung.com" <sbkim73@samsung.com>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"talgi@mellanox.com" <talgi@mellanox.com>,
"changbin.du@intel.com" <changbin.du@intel.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>
Subject: Re: [PATCH v6 06/10] regulator: use linear_ranges helper
Date: Wed, 25 Mar 2020 11:34:25 +0000 [thread overview]
Message-ID: <20200325113425.GC4346@sirena.org.uk> (raw)
In-Reply-To: <739a01454410a5d7acf231c92e5b3ffcae49d84c.camel@fi.rohmeurope.com>
[-- Attachment #1.1: Type: text/plain, Size: 1153 bytes --]
On Wed, Mar 25, 2020 at 06:58:56AM +0000, Vaittinen, Matti wrote:
> On Tue, 2020-03-24 at 14:24 +0000, Mark Brown wrote:
> > On Tue, Mar 24, 2020 at 10:30:54AM +0200, Matti Vaittinen wrote:
> > >
> > > - if (!(min_uV <= linear_max_uV && max_uV >= range-
> > > >min_uV))
> > > + ret = linear_range_get_selector_high(range, min_uV,
> > > &sel,
> > > + &found);
> > > + if (ret)
> > > continue;
> > Why are these going for _get_selector_high()? Usually we try to
> > choose
> > the lowest voltage we can.
> I tried to maintain the existing logic - which is (if I am not
> mistaken) to search for first value which is equal or higher than the
> minimum. Hence we use the linear_range_get_selector_high() - which does
> not return selector for voltage smaller than given value (minimum).
OK, that's a bit confusingly named then - I'd read that as finding the
highest value within the range without registering that the function
only takes a single value so can't verify if the selector is in range or
not. I'll also need to check that the modified code verifies that the
selector returned is within range.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-03-25 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 8:27 [PATCH v6 00/10] Support ROHM BD99954 charger IC Matti Vaittinen
2020-03-24 8:29 ` [PATCH v6 03/10] lib: add linear ranges helpers Matti Vaittinen
2020-03-24 14:16 ` Mark Brown
2020-03-27 19:34 ` Linus Walleij
2020-03-24 8:30 ` [PATCH v6 06/10] regulator: use linear_ranges helper Matti Vaittinen
2020-03-24 14:24 ` Mark Brown
2020-03-25 6:58 ` Vaittinen, Matti
2020-03-25 11:34 ` Mark Brown [this message]
2020-03-25 11:46 ` Vaittinen, Matti
2020-03-24 16:41 ` Charles Keepax
2020-03-24 16:48 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325113425.GC4346@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Gary.Hook@amd.com \
--cc=Markus.Laine@fi.rohmeurope.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=Mikko.Mutanen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrei.stefanescu@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=bp@suse.de \
--cc=brendanhiggins@google.com \
--cc=changbin.du@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mhiramat@kernel.org \
--cc=milo.kim@ti.com \
--cc=olteanv@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=sbkim73@samsung.com \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=talgi@mellanox.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=uwe@kleine-koenig.org \
--cc=vincenzo.frascino@arm.com \
--cc=wens@csie.org \
--cc=yamada.masahiro@socionext.com \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox