From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Fengping Yu <fengping.yu@mediatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Marco Felsch <m.felsch@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver
Date: Thu, 14 May 2020 13:30:42 +0300 [thread overview]
Message-ID: <20200514103042.GA185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200514102701.GZ185537@smile.fi.intel.com>
On Thu, May 14, 2020 at 01:27:01PM +0300, Andy Shevchenko wrote:
> On Thu, May 14, 2020 at 02:17:48PM +0800, Fengping Yu wrote:
> > From: "fengping.yu" <fengping.yu@mediatek.com>
> >
> > This adds matrix keypad support for Mediatek SoCs.
>
> ...
>
> > +config KEYBOARD_MTK_KPD
> > + tristate "MediaTek Keypad Support"
>
> > + depends on OF && HAVE_CLK
>
> What makes it OF dependent?
Actually you missed regmap dependencies or selection. I dunno which one should
be used (IIRC selection).
> > + help
> > + Say Y here if you want to use the keypad on MediaTek SoCs.
> > + If unsure, say N.
> > + To compile this driver as a module, choose M here: the
> > + module will be called mtk-kpd.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-05-14 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 6:17 [PATCH v7] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-05-14 6:17 ` [PATCH v7 1/3] dt-bindings: Add keypad devicetree documentation Fengping Yu
2020-05-14 9:31 ` Marco Felsch
2020-05-14 10:04 ` Matthias Brugger
2020-05-14 6:17 ` [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver Fengping Yu
2020-05-14 9:24 ` Marco Felsch
2020-05-14 10:27 ` Andy Shevchenko
2020-05-14 10:30 ` Andy Shevchenko [this message]
2020-05-14 6:17 ` [PATCH v7 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=y Fengping Yu
2020-05-14 8:56 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514103042.GA185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox