* [PATCH] ASoC: mediatek: mt8195: silence uninitialized variable warning
@ 2021-12-08 15:11 Dan Carpenter
2021-12-08 16:46 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-12-08 15:11 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
Trevor Wu, Bixuan Cui, Rikard Falkeborn, alsa-devel,
linux-mediatek, kernel-janitors
Smatch complains that we might hit the continue path on every iteration
through the loop.
sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c:831
mt8195_mt6359_rt1019_rt5682_card_late_probe()
error: uninitialized symbol 'sof_comp'.
Initialize "sof_comp" to NULL to silence this warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c b/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c
index b240610dcef0..11a185da0d96 100644
--- a/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c
+++ b/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c
@@ -813,7 +813,7 @@ static int mt8195_dai_link_fixup(struct snd_soc_pcm_runtime *rtd,
static int mt8195_mt6359_rt1019_rt5682_card_late_probe(struct snd_soc_card *card)
{
struct snd_soc_pcm_runtime *runtime;
- struct snd_soc_component *sof_comp;
+ struct snd_soc_component *sof_comp = NULL;
int i;
/* 1. find sof component */
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: mediatek: mt8195: silence uninitialized variable warning
2021-12-08 15:11 [PATCH] ASoC: mediatek: mt8195: silence uninitialized variable warning Dan Carpenter
@ 2021-12-08 16:46 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-12-08 16:46 UTC (permalink / raw)
To: Liam Girdwood, Dan Carpenter
Cc: Rikard Falkeborn, linux-mediatek, Trevor Wu, Bixuan Cui,
Jaroslav Kysela, Takashi Iwai, Matthias Brugger, alsa-devel,
kernel-janitors
On Wed, 8 Dec 2021 18:11:45 +0300, Dan Carpenter wrote:
> Smatch complains that we might hit the continue path on every iteration
> through the loop.
>
> sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c:831
> mt8195_mt6359_rt1019_rt5682_card_late_probe()
> error: uninitialized symbol 'sof_comp'.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: mediatek: mt8195: silence uninitialized variable warning
commit: 9abc21c966619d6ead27fd48481966014fdc680f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-08 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-08 15:11 [PATCH] ASoC: mediatek: mt8195: silence uninitialized variable warning Dan Carpenter
2021-12-08 16:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox