* [PATCH] Bluetooth: mt7921s: fix a NULL check
@ 2022-03-23 7:48 Dan Carpenter
2022-03-23 10:50 ` patchwork-bot+bluetooth
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-23 7:48 UTC (permalink / raw)
To: Marcel Holtmann, Yake Yang
Cc: Johan Hedberg, Luiz Augusto von Dentz, Matthias Brugger,
Sean Wang, Mark Chen, linux-bluetooth, linux-mediatek,
kernel-janitors
There is a typo in the NULL check so it's never true. It should be
checking "*ven_data" instead of "ven_data".
Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
}
*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
- if (!ven_data) {
+ if (!*ven_data) {
err = -ENOMEM;
goto error;
}
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: mt7921s: fix a NULL check
2022-03-23 7:48 [PATCH] Bluetooth: mt7921s: fix a NULL check Dan Carpenter
@ 2022-03-23 10:50 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-23 10:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: marcel, yake.yang, johan.hedberg, luiz.dentz, matthias.bgg,
sean.wang, markyawenchen, linux-bluetooth, linux-mediatek,
kernel-janitors
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Wed, 23 Mar 2022 10:48:30 +0300 you wrote:
> There is a typo in the NULL check so it's never true. It should be
> checking "*ven_data" instead of "ven_data".
>
> Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- Bluetooth: mt7921s: fix a NULL check
https://git.kernel.org/bluetooth/bluetooth-next/c/864cc8a234cd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-23 7:48 [PATCH] Bluetooth: mt7921s: fix a NULL check Dan Carpenter
2022-03-23 10:50 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).