Re: [PATCH 1/2] pwm: mediatek: Add support for MT7986

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

On Tue, Oct 25, 2022 at 02:35:43PM +0800, Sam Shih wrote:
> Hi Daniel:
> 
> On Fri, 2022-10-21 at 16:24 +0100, Daniel Golle wrote:
> > Add support for PWM on MT7986 which has 2 PWM channels, one of them
> > is
> > typically used for a temperature controlled fan.
> > 
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> >  drivers/pwm/pwm-mediatek.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> > index 6901a44dc428de..2219cba033e348 100644
> > --- a/drivers/pwm/pwm-mediatek.c
> > +++ b/drivers/pwm/pwm-mediatek.c
> > @@ -329,6 +329,12 @@ static const struct pwm_mediatek_of_data
> > mt8365_pwm_data = {
> >  	.has_ck_26m_sel = true,
> >  };
> >  
> > +static const struct pwm_mediatek_of_data mt7986_pwm_data = {
> > +	.num_pwms = 2,
> > +	.pwm45_fixup = false,
> > +	.has_ck_26m_sel = true,
> 
> For MT7986 SoC, I think the value of "has_ck_26m_sel" should be 'false' 

The status of the discussion isn't clear to me. You didn't visibly agree
which value is right now. Will there be a v2 of this patch? Or is it
expected to be picked up as is.

From my side (i.e. not having checked the hw details just judging with
the PWM hat on) the patch is fine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]