Re: [PATCH 1/2] pwm: mediatek: Add support for MT7986

[Sam Shih <sam.shih@mediatek.com>]

Hi Daniel:

On Fri, 2022-10-21 at 16:24 +0100, Daniel Golle wrote:
> Add support for PWM on MT7986 which has 2 PWM channels, one of them
> is
> typically used for a temperature controlled fan.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
>  drivers/pwm/pwm-mediatek.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index 6901a44dc428de..2219cba033e348 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -329,6 +329,12 @@ static const struct pwm_mediatek_of_data
> mt8365_pwm_data = {
>  	.has_ck_26m_sel = true,
>  };
>  
> +static const struct pwm_mediatek_of_data mt7986_pwm_data = {
> +	.num_pwms = 2,
> +	.pwm45_fixup = false,
> +	.has_ck_26m_sel = true,

For MT7986 SoC, I think the value of "has_ck_26m_sel" should be 'false' 

> +};
> +
>  static const struct pwm_mediatek_of_data mt8516_pwm_data = {
>  	.num_pwms = 5,
>  	.pwm45_fixup = false,
> @@ -342,6 +348,7 @@ static const struct of_device_id
> pwm_mediatek_of_match[] = {
>  	{ .compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data
> },
>  	{ .compatible = "mediatek,mt7628-pwm", .data = &mt7628_pwm_data
> },
>  	{ .compatible = "mediatek,mt7629-pwm", .data = &mt7629_pwm_data
> },
> +	{ .compatible = "mediatek,mt7986-pwm", .data = &mt7986_pwm_data
> },
>  	{ .compatible = "mediatek,mt8183-pwm", .data = &mt8183_pwm_data
> },
>  	{ .compatible = "mediatek,mt8365-pwm", .data = &mt8365_pwm_data
> },
>  	{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data
> },

Regards,
Sam