[PATCH][next] ASoC: mediatek: mt8188: Fix uninitialized variable msk

[PATCH][next] ASoC: mediatek: mt8188: Fix uninitialized variable msk

[Colin Ian King]

The variable msk not initialized and is being bit-wise or'd with values
in a for-loop, leading to an undefined result. Fix this by initializing
msk to zero before the for-loop.

Fixes: c1e42ec04197 ("ASoC: mediatek: mt8188: Add support for DMIC")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 sound/soc/mediatek/mt8188/mt8188-dai-dmic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-dmic.c b/sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
index 4cfbcb71d2d9..adcea7818be2 100644
--- a/sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
+++ b/sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
@@ -307,6 +307,7 @@ static int mtk_dmic_event(struct snd_soc_dapm_widget *w,
 	switch (event) {
 	case SND_SOC_DAPM_PRE_PMU:
 		/* request fifo soft rst */
+		msk = 0;
 		for (i = dmic_num; i >= DMIC0; i--)
 			msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
 
-- 
2.47.2

Re: [PATCH][next] ASoC: mediatek: mt8188: Fix uninitialized variable msk

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

On Wed, Feb 26, 2025 at 04:18:47PM +0000, Colin Ian King wrote:
> The variable msk not initialized and is being bit-wise or'd with values
> in a for-loop, leading to an undefined result. Fix this by initializing
> msk to zero before the for-loop.

Arnd sent a version of this that picked up reviews from the Mediatek
people so I applied that one, should be fixed in tomorrow's -next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]