Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers
@ 2025-03-13  4:08 Vignesh Raman
  2025-03-13 12:49 ` Nícolas F. R. A. Prado
  0 siblings, 1 reply; 2+ messages in thread
From: Vignesh Raman @ 2025-03-13  4:08 UTC (permalink / raw)
  To: linux-mediatek
  Cc: chunkuang.hu, p.zabel, nfraprado, angelogioacchino.delregno, krzk,
	daniels, airlied, simona.vetter, arnd, ck.hu, laura.nao,
	matthias.bgg, tzimmermann, mripard, lumag, ville.syrjala,
	jani.nikula, arnd, geert+renesas, wenst, linux-arm-kernel,
	dri-devel, linux-kernel

The mediatek display driver fails to probe on mt8173-elm-hana and
mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
configurations.

Commit [1] stopped selecting the MediaTek PHY drivers, requiring them
to be explicitly enabled in defconfig.

Enable the following PHY drivers for MediaTek platforms:
- CONFIG_PHY_MTK_HDMI=m for HDMI display
- CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
- CONFIG_PHY_MTK_DP=m for DP display

[1] commit 924d66011f24 ("drm/mediatek: stop selecting foreign drivers")

Fixes: 924d66011f24 ("drm/mediatek: stop selecting foreign drivers")
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---

v2:
  - Include board details in the commit message.  
  - Sort newly added PHY configs in defconfig.

v3:
  - Use defconfig/savedefconfig to get the correct configs ordering.
  - Removed PHY_MTK_XSPHY since it is not required for probing display driver.
  - Add the commit details which deselected the MediaTek PHY drivers and
    added a Fixes tag.
  - Enabled CONFIG_PHY_MTK_DP, which was previously deselected.

---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1f25423de383..fa8ee7070b37 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1573,6 +1573,9 @@ CONFIG_PHY_HISTB_COMBPHY=y
 CONFIG_PHY_HISI_INNO_USB2=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
 CONFIG_PHY_MTK_TPHY=y
+CONFIG_PHY_MTK_HDMI=m
+CONFIG_PHY_MTK_MIPI_DSI=m
+CONFIG_PHY_MTK_DP=m
 CONFIG_PHY_QCOM_EDP=m
 CONFIG_PHY_QCOM_PCIE2=m
 CONFIG_PHY_QCOM_QMP=m
-- 
2.47.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers
  2025-03-13  4:08 [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers Vignesh Raman
@ 2025-03-13 12:49 ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 2+ messages in thread
From: Nícolas F. R. A. Prado @ 2025-03-13 12:49 UTC (permalink / raw)
  To: Vignesh Raman
  Cc: linux-mediatek, chunkuang.hu, p.zabel, angelogioacchino.delregno,
	krzk, daniels, airlied, simona.vetter, arnd, ck.hu, laura.nao,
	matthias.bgg, tzimmermann, mripard, lumag, ville.syrjala,
	jani.nikula, arnd, geert+renesas, wenst, linux-arm-kernel,
	dri-devel, linux-kernel

On Thu, Mar 13, 2025 at 09:38:24AM +0530, Vignesh Raman wrote:
> The mediatek display driver fails to probe on mt8173-elm-hana and
> mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
> configurations.
> 
> Commit [1] stopped selecting the MediaTek PHY drivers, requiring them
> to be explicitly enabled in defconfig.
> 
> Enable the following PHY drivers for MediaTek platforms:
> - CONFIG_PHY_MTK_HDMI=m for HDMI display
> - CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
> - CONFIG_PHY_MTK_DP=m for DP display
> 
> [1] commit 924d66011f24 ("drm/mediatek: stop selecting foreign drivers")

Usually this would go directly in the paragraph, like so:

  Commit 924d66011f24 ("drm/mediatek: stop selecting foreign drivers") stopped
  selecting the MediaTek PHY drivers, requiring them to be explicitly enabled in
  defconfig.

But that's just so you know in the future, you don't need to send a new version
just for that.

> 
> Fixes: 924d66011f24 ("drm/mediatek: stop selecting foreign drivers")
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-13 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13  4:08 [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers Vignesh Raman
2025-03-13 12:49 ` Nícolas F. R. A. Prado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox