* [PATCH] wifi: mt76: mt7996: avoid NULL pointer dereference in mt7996_set_monitor()
@ 2025-03-22 10:50 Qasim Ijaz
2025-03-22 13:40 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Qasim Ijaz @ 2025-03-22 10:50 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, matthias.bgg,
angelogioacchino.delregno, chui-hao.chiu, Bo.Jiao
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek
The function mt7996_set_monitor() dereferences phy before
the NULL sanity check.
Fix this to avoid NULL pointer dereference by moving the
dereference after the check.
Fixes: 69d54ce7491d ("wifi: mt76: mt7996: switch to single multi-radio wiphy")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
drivers/net/wireless/mediatek/mt76/mt7996/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
index 91c64e3a0860..66575698aef1 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
@@ -414,11 +414,13 @@ static void mt7996_phy_set_rxfilter(struct mt7996_phy *phy)
static void mt7996_set_monitor(struct mt7996_phy *phy, bool enabled)
{
- struct mt7996_dev *dev = phy->dev;
+ struct mt7996_dev *dev;
if (!phy)
return;
+ dev = phy->dev;
+
if (enabled == !(phy->rxfilter & MT_WF_RFCR_DROP_OTHER_UC))
return;
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: mt76: mt7996: avoid NULL pointer dereference in mt7996_set_monitor()
2025-03-22 10:50 [PATCH] wifi: mt76: mt7996: avoid NULL pointer dereference in mt7996_set_monitor() Qasim Ijaz
@ 2025-03-22 13:40 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-03-22 13:40 UTC (permalink / raw)
To: Qasim Ijaz, linux-wireless, linux-mediatek, linux-arm-kernel
Cc: LKML, Angelo Gioacchino Del Regno, Bo Jiao, Dan Carpenter,
Felix Fietkau, Johannes Berg, Lorenzo Bianconi, Matthias Brugger,
Peter Chiu, Ryder Lee, Sean Wang, Shayne Chen
> The function mt7996_set_monitor() dereferences phy before
> the NULL sanity check.
>
> Fix this to avoid NULL pointer dereference by moving the
> dereference after the check.
Were any known source code analysis tools involved for this software improvement?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-22 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-22 10:50 [PATCH] wifi: mt76: mt7996: avoid NULL pointer dereference in mt7996_set_monitor() Qasim Ijaz
2025-03-22 13:40 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox