[PATCH v2] ufs: core: behavior change of hwq_id type and value

[PATCH v2] ufs: core: behavior change of hwq_id type and value

[peter.wang]

From: Peter Wang <peter.wang@mediatek.com>

Because the member id of struct ufs_hw_queue is u32 (hwq->id) and
the trace entry hwq_id is also u32, the type should be changed to u32.
If mcq is not supported, SDB mode only supports one hardware queue,
for which setting the hwq_id to 0 is more suitable.

Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
 drivers/ufs/core/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 7735421e3991..14e4cfbcb9eb 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -432,7 +432,7 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
 	u8 opcode = 0, group_id = 0;
 	u32 doorbell = 0;
 	u32 intr;
-	int hwq_id = -1;
+	u32 hwq_id = 0;
 	struct ufshcd_lrb *lrbp = &hba->lrb[tag];
 	struct scsi_cmnd *cmd = lrbp->cmd;
 	struct request *rq = scsi_cmd_to_rq(cmd);
-- 
2.45.2

Re: [PATCH v2] ufs: core: behavior change of hwq_id type and value

[Bart Van Assche]

On 5/8/25 2:18 AM, peter.wang@mediatek.com wrote:
> From: Peter Wang <peter.wang@mediatek.com>

Patch descriptions, including the subject, should use the imperative
mood. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH v2] ufs: core: behavior change of hwq_id type and value

[Peter Wang (王信友)]

On Thu, 2025-05-08 at 08:20 -0700, Bart Van Assche wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 5/8/25 2:18 AM, peter.wang@mediatek.com wrote:
> > From: Peter Wang <peter.wang@mediatek.com>
> 
> Patch descriptions, including the subject, should use the imperative
> mood. Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>


Hi Bart,

Okay, I will use the imperative mood for patch descriptions. 
Thanks for the review.

Peter