Re: [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Fri, Jun 26, 2026 at 10:33:20AM +0200, Philipp Zabel wrote:

> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    ufs0cfg_ao: syscon@16840000 {
> > +        compatible = "mediatek,mt8183-ufs0cfg_ao", "syscon", "simple-mfd";
> 
> Where is the binding doc for mediatek,mt8183-ufs0cfg_ao? Is this
> simple-mfd just to load the reset driver?

It isn't going to exist, since we will chuck a fit at the underscore!

> 
> > +        reg = <0x16840000 0x1000>;
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +
> > +        ufs0cfgao_rst: reset-controller {
> > +            compatible = "mediatek,syscon-reset";
> 
> It looks to me like this is just two registers inside ufs0cfg_ao, not a
> separate device. Why don't you just add #reset-cells to the parent
> node?

I concur, seems like it should be in the parent.
pw-bot: changes-requested

> 
> > +            #reset-cells = <1>;
> > +            mediatek,reset-bits =
> > +                <0x48  3  0x4c  3  100>,
> > +                <0x148 0  0x14c 0  100>,
> > +                <0x148 1  0x14c 1  100>,
> > +                <0x148 2  0x14c 2  0>;
> > +        };
> 
> Why is this in DT? This should be a table in the reset driver.
> 
> regards
> Philipp

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]