Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML - allen-kh.cheng

From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
Cc: Lala Lin <lala.lin@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML
Date: Tue, 26 Apr 2022 18:03:11 +0800	[thread overview]
Message-ID: <23e170f94a541eca5a1a601cbb130c619d3fa3a9.camel@mediatek.com> (raw)
In-Reply-To: <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org>

Hi Krzysztof,

On Tue, 2022-04-26 at 08:31 +0200, Krzysztof Kozlowski wrote:
> On 26/04/2022 08:23, allen-kh.cheng wrote:
> > > > +properties:
> > > > +  compatible:
> > > > +    oneOf:
> > > > +      - enum:
> > > > +          - mediatek,mt8173-efuse
> > > > +          - mediatek,efuse
> > > 
> > > Still no changes...
> > > 
> > 
> > I just want to confirm again.
> > 
> > "Generic compatibles should not be used standalone"
> > 
> > It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
> > efuse"in binding. have I got that right?
> 
> You should comment for which chipsets this compatible is and add a
> deprecated:true. In such case it cannot be part of enum but separate
> item in this oneOf.
> 
> 
> Best regards,
> Krzysztof

Thanks for your suggestions, I would plan to send PATCHs as below,

We have a PATCH 01 for current accepted dts

properties:
  compatible:
    oneOf:
      - enum:
        - mediatek,efuse

        - mediatek,mt8173-efuse
        description: Only mt8173-efuse
with generic fallback should be used
      - items:
          - enum:

- mediatek,mt7622-efuse
			  ...
          - const: mediatek,efuse

Then add PATCH 02 to deprecate it

properties:
  compatible:
    oneOf:
      - enum:
        - mediatek,efuse
        - mediatek,mt8173-efuse
        deprecated: true
        description: The mediatek,efuse is a generic fallback for other
Chipset. Do not use the single compatible such as mediatek,efuse
or mediatek,mt8173-efuse. It is deprecated.
      - items:
          - enum:
              - mediatek,mt7622-efuse
              ...
          - const: mediatek,efuse

PATCH 03 for 8173

update mt8173.dtsi 

change compatible from "mediatek,mt8173-efuse" to "mediatek,mt8173-
efuse", "mediatek,efuse";

Do you think it'd be okay ?

Best regards,
Allen

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek