Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML

[allen-kh.cheng <allen-kh.cheng@mediatek.com>]

Hi Krzysztof,

On Mon, 2022-04-25 at 18:38 +0200, Krzysztof Kozlowski wrote:
> On 25/04/2022 10:48, Allen-KH Cheng wrote:
> > Convert MediaTek eFuse devicetree binding to YAML.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> >  .../devicetree/bindings/nvmem/mtk,efuse.yaml  | 70
> > +++++++++++++++++++
> 
> The vendor prefix is mediatek. Quoting my previous reply:
> 
>   Same comments as usual, so "vendor,device-name", e.g.
> "mediatek,efuse"
>   if this is going to match all possible future MediaTek chips or
>   "mediatek,mt7622-efuse"
> 
> so keep it mediatek,efuse.yaml.
> 

Yes, this can match can match current MTK chips.

I will keep the file name.

> >  .../devicetree/bindings/nvmem/mtk-efuse.txt   | 43 ------------
> >  2 files changed, 70 insertions(+), 43 deletions(-)
> >  create mode 100644
> > Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/nvmem/mtk-
> > efuse.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml
> > b/Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml
> > new file mode 100644
> > index 000000000000..d056bc61dd5b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/nvmem/mtk,efuse.yaml*__;Iw!!CTRNKA9wMg0ARbw!2opCfMBuhT3qG85-CIdLu3yviYqRI08FFlpx4vGOKsJLRgOilZDcv1zCy75fOabzogXR6t7cqOrvYULjSab_7sq-qA$
> >  
> > +$schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!2opCfMBuhT3qG85-CIdLu3yviYqRI08FFlpx4vGOKsJLRgOilZDcv1zCy75fOabzogXR6t7cqOrvYULjSaY9-kvJ9A$
> >  
> > +
> > +title: MediaTek eFuse device tree bindings
> 
> No changes here. Please read my comments from your v1, don't ignore
> them.
> 

My apologies for the mistake, I see the reply of v1 after I send v2. 

I will remove "device tree bindings".

> > +
> > +maintainers:
> > +  - Lala Lin <lala.lin@mediatek.com>
> > +  - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > +
> > +allOf:
> > +  - $ref: "nvmem.yaml#"
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - enum:
> > +          - mediatek,mt8173-efuse
> > +          - mediatek,efuse
> 
> Still no changes...
> 

I just want to confirm again.

"Generic compatibles should not be used standalone"

It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
efuse"in binding. have I got that right?


> > +      - items:
> > +          - enum:
> > +              - mediatek,mt7622-efuse
> > +              - mediatek,mt7623-efuse
> > +              - mediatek,mt8183-efuse
> > +              - mediatek,mt8192-efuse
> > +              - mediatek,mt8195-efuse
> > +              - mediatek,mt8516-efuse
> > +          - const: mediatek,efuse
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +patternProperties:
> > +  "^.*@[0-9a-f]+$":
> > +    type: object
> > +
> > +    properties:
> > +      reg:
> > +        maxItems: 1
> > +        description:
> > +          Offset and size in bytes within the storage device.
> > +
> > +    required:
> > +      - reg
> > +
> > +    additionalProperties: false
> 
> Still no changes.
> 

Will remove this.

Thanks,
Allen

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +
> 
> Still no changes.
> 
> 
> Best regards,
> Krzysztof


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek