From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Huayu Zong <huayu.zong@mediatek.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tinghan Shen <tinghan.shen@mediatek.com>
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 2/2] remoteproc: mediatek: Support MT8189 SCP
Date: Wed, 24 Sep 2025 12:12:36 +0200 [thread overview]
Message-ID: <30a75332-a7f9-41ed-a4e8-520b1e7c9bfe@collabora.com> (raw)
In-Reply-To: <20250924084422.4604-3-huayu.zong@mediatek.com>
Il 24/09/25 10:44, Huayu Zong ha scritto:
> Add SCP support for mt8189.
>
Please split this in at least two commits, with the last one adding only the
MT8189 platform data and compatible.
Also, please clearly describe the new scp_secure_domain_reg write, as the current
comment is not clear at all.
Anyway - the code looks good overall.
Cheers,
Angelo
> Signed-off-by: Huayu Zong <huayu.zong@mediatek.com>
next prev parent reply other threads:[~2025-09-24 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 8:44 [PATCH v2 0/2] Add support for MT8189 SCP and device tree bindings Huayu Zong
2025-09-24 8:44 ` [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8189 scp Huayu Zong
2025-09-24 10:15 ` AngeloGioacchino Del Regno
2025-09-24 8:44 ` [PATCH v2 2/2] remoteproc: mediatek: Support MT8189 SCP Huayu Zong
2025-09-24 10:12 ` AngeloGioacchino Del Regno [this message]
2025-09-25 6:23 ` Huayu Zong (纵华宇)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30a75332-a7f9-41ed-a4e8-520b1e7c9bfe@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huayu.zong@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox