From: "Huayu Zong (纵华宇)" <Huayu.Zong@mediatek.com>
To: "TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"andersson@kernel.org" <andersson@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>
Cc: "linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2 2/2] remoteproc: mediatek: Support MT8189 SCP
Date: Thu, 25 Sep 2025 06:23:30 +0000 [thread overview]
Message-ID: <8440e84b5e1c49025e677aefae96710a7461f477.camel@mediatek.com> (raw)
In-Reply-To: <30a75332-a7f9-41ed-a4e8-520b1e7c9bfe@collabora.com>
On Wed, 2025-09-24 at 12:12 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Il 24/09/25 10:44, Huayu Zong ha scritto:
> > Add SCP support for mt8189.
> >
>
> Please split this in at least two commits, with the last one adding
> only the
> MT8189 platform data and compatible.
>
> Also, please clearly describe the new scp_secure_domain_reg write, as
> the current
> comment is not clear at all.
>
> Anyway - the code looks good overall.
>
> Cheers,
> Angelo
>
Thanks.
I will split this commit in 2 commits, one is platform data (mtk_scp.c
& mtk_common.h file) and the other commit include strcut element
define, function modification.
I will add more about scp_secure_domain comment.
> > Signed-off-by: Huayu Zong <huayu.zong@mediatek.com>
prev parent reply other threads:[~2025-09-25 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 8:44 [PATCH v2 0/2] Add support for MT8189 SCP and device tree bindings Huayu Zong
2025-09-24 8:44 ` [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8189 scp Huayu Zong
2025-09-24 10:15 ` AngeloGioacchino Del Regno
2025-09-24 8:44 ` [PATCH v2 2/2] remoteproc: mediatek: Support MT8189 SCP Huayu Zong
2025-09-24 10:12 ` AngeloGioacchino Del Regno
2025-09-25 6:23 ` Huayu Zong (纵华宇) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8440e84b5e1c49025e677aefae96710a7461f477.camel@mediatek.com \
--to=huayu.zong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox