Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	MandyJH Liu <mandyjh.liu@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: dts: mediatek: mt8365: drop incorrect power-domain-cells
Date: Mon, 20 May 2024 11:58:15 +0200	[thread overview]
Message-ID: <3b1be547-ac49-40fb-909f-96952c299545@collabora.com> (raw)
In-Reply-To: <20240518211159.142920-3-krzysztof.kozlowski@linaro.org>

Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto:
> The top SCPSYS node is not a power domain provider.  It's child
> "power-controller" is instead.  Fix dtbs_check warnings like:
> 
>    mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Well if you're fixing that by migrating to scpsys compatible, you might as well
resolve all of the warnings in one commit, removing that power-domain-cells
property in patch [2/4], otherwise this one is technically a fix for that.

Please squash [2/4] and [3/4], like that it just makes more sense.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt8365.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index d3da5a22c2d2..eb449bfa8803 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -302,7 +302,6 @@ syscfg_pctl: syscfg-pctl@10005000 {
>   		scpsys: syscon@10006000 {
>   			compatible = "mediatek,mt8365-scpsys", "syscon", "simple-mfd";
>   			reg = <0 0x10006000 0 0x1000>;
> -			#power-domain-cells = <1>;
>   
>   			/* System Power Manager */
>   			spm: power-controller {



  reply	other threads:[~2024-05-20  9:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 21:11 [PATCH 1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys Krzysztof Kozlowski
2024-05-18 21:11 ` [PATCH 2/4] arm64: dts: mediatek: mt8365: use a specific SCPSYS compatible Krzysztof Kozlowski
2024-05-20  9:55   ` AngeloGioacchino Del Regno
2024-05-20 10:03     ` Krzysztof Kozlowski
2024-05-20 10:12       ` AngeloGioacchino Del Regno
2024-05-20 15:23         ` Alexandre Mergnat
2024-05-21  8:22           ` Krzysztof Kozlowski
2024-05-21 13:26             ` Alexandre Mergnat
2024-05-21 14:13               ` AngeloGioacchino Del Regno
2024-05-21 17:28                 ` Alexandre Mergnat
2024-05-18 21:11 ` [PATCH 3/4] arm64: dts: mediatek: mt8365: drop incorrect power-domain-cells Krzysztof Kozlowski
2024-05-20  9:58   ` AngeloGioacchino Del Regno [this message]
2024-05-20 10:03     ` Krzysztof Kozlowski
2024-05-20 10:06       ` AngeloGioacchino Del Regno
2024-05-18 21:11 ` [PATCH 4/4] arm64: dts: mediatek: mt8173-elm: correct PMIC's syscon reg entry Krzysztof Kozlowski
2024-05-20 10:07   ` AngeloGioacchino Del Regno
2024-05-20 13:11     ` Krzysztof Kozlowski
2024-05-20  9:59 ` [PATCH 1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys AngeloGioacchino Del Regno
2024-05-20 21:02 ` Rob Herring (Arm)
2024-05-21 17:36 ` Alexandre Mergnat
2024-05-31 13:57 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b1be547-ac49-40fb-909f-96952c299545@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mandyjh.liu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox