From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
MandyJH Liu <mandyjh.liu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Alexandre Mergnat <amergnat@baylibre.com>
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: mt8365: use a specific SCPSYS compatible
Date: Mon, 20 May 2024 12:12:08 +0200 [thread overview]
Message-ID: <cf8c87fe-7a4f-423f-9c97-3759eeee4894@collabora.com> (raw)
In-Reply-To: <2cc638ca-0add-4c8c-b844-606e22dbd253@linaro.org>
Il 20/05/24 12:03, Krzysztof Kozlowski ha scritto:
> On 20/05/2024 11:55, AngeloGioacchino Del Regno wrote:
>> Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto:
>>> SoCs should use dedicated compatibles for each of their syscon nodes to
>>> precisely describe the block. Using an incorrect compatible does not
>>> allow to properly match/validate children of the syscon device. Replace
>>> SYSCFG compatible, which does not have children, with a new dedicated
>>> one for SCPSYS block.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Technically, that's not a SCPSYS block, but called SYSCFG in MT8365, but the
>> meaning and the functioning is the same, so it's fine for me.
>
> So there are two syscfg blocks? With exactly the same set of registers
> or different?
>
I'm not sure about that, I don't have the MT8365 datasheet...
Adding Alexandre to the loop - I think he can clarify as he should have the
required documentation.
Cheers
next prev parent reply other threads:[~2024-05-20 10:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 21:11 [PATCH 1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys Krzysztof Kozlowski
2024-05-18 21:11 ` [PATCH 2/4] arm64: dts: mediatek: mt8365: use a specific SCPSYS compatible Krzysztof Kozlowski
2024-05-20 9:55 ` AngeloGioacchino Del Regno
2024-05-20 10:03 ` Krzysztof Kozlowski
2024-05-20 10:12 ` AngeloGioacchino Del Regno [this message]
2024-05-20 15:23 ` Alexandre Mergnat
2024-05-21 8:22 ` Krzysztof Kozlowski
2024-05-21 13:26 ` Alexandre Mergnat
2024-05-21 14:13 ` AngeloGioacchino Del Regno
2024-05-21 17:28 ` Alexandre Mergnat
2024-05-18 21:11 ` [PATCH 3/4] arm64: dts: mediatek: mt8365: drop incorrect power-domain-cells Krzysztof Kozlowski
2024-05-20 9:58 ` AngeloGioacchino Del Regno
2024-05-20 10:03 ` Krzysztof Kozlowski
2024-05-20 10:06 ` AngeloGioacchino Del Regno
2024-05-18 21:11 ` [PATCH 4/4] arm64: dts: mediatek: mt8173-elm: correct PMIC's syscon reg entry Krzysztof Kozlowski
2024-05-20 10:07 ` AngeloGioacchino Del Regno
2024-05-20 13:11 ` Krzysztof Kozlowski
2024-05-20 9:59 ` [PATCH 1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys AngeloGioacchino Del Regno
2024-05-20 21:02 ` Rob Herring (Arm)
2024-05-21 17:36 ` Alexandre Mergnat
2024-05-31 13:57 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8c87fe-7a4f-423f-9c97-3759eeee4894@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox