Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/01/2025 03:42, Jason-JH Lin (林睿祥) wrote:
>>
>> Before proceeding with this header further, please answer to above -
>> why
>> interrupt numbers, MMIO addresses and some other values appearing in
>> DTS
>> are not used like "binding headers".
> 
> Because interrupt numbers and MMIO addresses are the real numbers of
> hardware settings. Their driver can get them directly from their device
> node in DTS. They are actual number to be set into their hardware, so
> they don't need to be translated in their platform drivers.
> 
> So I think all the definitions in the `mediatek,mt8196-gce.h` are the
> same case. They are actual hardware numbers for GCE hardware to use.
> It should be drop from the include/dt-bindings/*.

I did not inspect all of the defines you have there. Maybe some are used
by driver, so I did not provide you definitive answer on entire header.
The comment was addressing one specific group of defines which were not
used as a binding.

> 
> 
> BTW, to make these numbers more readable in DTS, can I move
> `include/dt-bindings/mailbox/mediatek,mt8196-gce.h` into
> `arch/arm64/boot/dts/mediatek/mt8196-gce.h`?

Yes, sure.

> 
> Just like the `arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h`.

Best regards,
Krzysztof