Re: [PATCH 3/5] arm64: dts: mt8192: Add display nodes

[allen-kh.cheng <allen-kh.cheng@mediatek.com>]

Hi Chen-Yu,

On Fri, 2022-07-01 at 13:25 +0800, Chen-Yu Tsai wrote:
> On Thu, Jun 30, 2022 at 9:42 PM Nícolas F. R. A. Prado
> <nfraprado@collabora.com> wrote:
> > 
> > On Thu, Jun 30, 2022 at 05:41:31PM +0800, allen-kh.cheng wrote:
> > > Hi Nícolas,
> > > 
> > > On Wed, 2022-06-29 at 19:24 -0400, Nícolas F. R. A. Prado wrote:
> > > > On Wed, Jun 29, 2022 at 08:13:56PM +0800, Allen-KH Cheng wrote:
> > > > > Add display nodes and gce info for mt8192 SoC.
> > > > > 
> > > > > GCE (Global Command Engine) properties to the display nodes
> > > > > in
> > > > > order to
> > > > > enable the usage of the CMDQ (Command Queue), which is
> > > > > required for
> > > > > operating the display.
> > > > > 
> > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > > > > Reviewed-by: AngeloGioacchino Del Regno <
> > > > > angelogioacchino.delregno@collabora.com>
> > > > > ---
> > > > >  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 136
> > > > > +++++++++++++++++++++++
> > > > >  1 file changed, 136 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > > index a07edc82d403..26d01544b4ea 100644
> > > > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > 
> > [..]
> > > > > +         rdma0: rdma@14007000 {
> > > > > +                 compatible = "mediatek,mt8192-disp-rdma";
> > > > 
> > > > dtbs_check is complaining that there isn't a "mediatek,mt8183-
> > > > disp-
> > > > rdma"
> > > > fallback compatible here. But given that the rdma driver
> > > > matches
> > > > directly to the
> > > > mt8192 compatible, I think the node here is fine, and the
> > > > binding is
> > > > the one
> > > > that should be updated.
> > > > 
> > > 
> > > I have checked the binding and driver again.
> > > 
> > > I prefer use "mediatek,mt8186-disp-rdma" as fallback and remove
> > > mt8192
> > > compatible and data in mtk_disp_rdma.c because they are the same
> > > with
> > > mt8183.
> > > 
> > > Do you think it is okay?
> > 
> > Sure, that sounds good to me as well.
> 
> That's backwards. MT8192 was released well before MT8186. The latter
> hasn't
> even hit the market yet.
> 
> Please use "mediatek,mt8183-disp-rdma" as fallback. And you need to
> keep
> "mediatek,mt8192-disp-rdma" as the most specific compatible string,
> because
> we want SoC specific compatible strings.
> 
> For the driver, there isn't any difference between mt8183 and mt8192
> for
> the rdma part, so we might as well just remove the mt8192 compatible
> from
> the driver.
> 
> 
> Regards
> ChenYu

Yes, I agree with you. it appears that for some reasons I made a typo
in my repy.

I will use "mediatek,mt8183-disp-rdma" as fallback in next version.

Thanks,
Allen