Re: [PATCH 3/5] arm64: dts: mt8192: Add display nodes

[allen-kh.cheng <allen-kh.cheng@mediatek.com>]

Hi Nícolas, 

On Wed, 2022-06-29 at 19:24 -0400, Nícolas F. R. A. Prado wrote:
> On Wed, Jun 29, 2022 at 08:13:56PM +0800, Allen-KH Cheng wrote:
> > Add display nodes and gce info for mt8192 SoC.
> > 
> > GCE (Global Command Engine) properties to the display nodes in
> > order to
> > enable the usage of the CMDQ (Command Queue), which is required for
> > operating the display.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 136
> > +++++++++++++++++++++++
> >  1 file changed, 136 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index a07edc82d403..26d01544b4ea 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> 
> [..]
> >  
> > +		mutex: mutex@14001000 {
> > +			compatible = "mediatek,mt8192-disp-mutex";
> > +			reg = <0 0x14001000 0 0x1000>;
> > +			interrupts = <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > +			clocks = <&mmsys CLK_MM_DISP_MUTEX0>;
> > +			mediatek,gce-events =
> > <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_0>,
> > +					      <CMDQ_EVENT_DISP_STREAM_D
> > ONE_ENG_EVENT_1>;
> 
> This node is missing power-domains.
> 
> > +		};
> > 
> 
> [..]
> > +		rdma0: rdma@14007000 {
> > +			compatible = "mediatek,mt8192-disp-rdma";
> 
> dtbs_check is complaining that there isn't a "mediatek,mt8183-disp-
> rdma"
> fallback compatible here. But given that the rdma driver matches
> directly to the
> mt8192 compatible, I think the node here is fine, and the binding is
> the one
> that should be updated.
> 

I have checked the binding and driver again.

I prefer use "mediatek,mt8186-disp-rdma" as fallback and remove mt8192
compatible and data in mtk_disp_rdma.c because they are the same with
mt8183.

Do you think it is okay?

Thanks,
Allen


> > +			reg = <0 0x14007000 0 0x1000>;
> > +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > +			clocks = <&mmsys CLK_MM_DISP_RDMA0>;
> > +			iommus = <&iommu0 M4U_PORT_L0_DISP_RDMA0>;
> > +			mediatek,larb = <&larb0>;
> 
> mediatek,larb is no longer used, so drop it.
> 
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> Thanks,
> Nícolas