Re: [PATCH v2 0/6] Add support for MT8196 video encoder

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

Hi,

Le mercredi 28 mai 2025 à 14:36 +0800, Irui Wang a écrit :
> This patch series add support for MT8196 video encoder.
> patch 1~3: Add a new encoder driver interface for new VCP firmware.
> patch 4~6: Add MT8196 encoder driver platform data.
> 
> About adding new driver support, the v4l2-compliance report shows:
> "Total for mtk-vcodec-enc device /dev/video3: 47, Succeeded: 46, Failed: 1, Warnings: 0"
> The 1 Failed case is not caused by current patch set.

We really want to see the full report, simply reply to this cover letter with
the entire report to fix it.

Nicolas

> 
> This patch set depends on "media: mediatek: vcodec: support video decoder in mt8196"[1]
> 
> [1] https://patchwork.linuxtv.org/project/linux-media/list/?series=15232
> 
> Change in v2:
>  - Add support for VCP encode process.
>  - Add MT8196 encoder driver platform data.
>  - Rebase encoder patch onto decoder's patch set.
>  - Fix some review comments in v1.
> 
> Irui Wang (6):
>   media: mediatek: encoder: Add a new encoder driver interface
>   media: mediatek: encoder: Add support for common firmware interface
>   media: mediatek: encoder: Add support for VCP encode process
>   media: mediatek: encoder: Add a new platform data member
>   dt-bindings: media: mediatek: encoder: Add encoder dt-bindings for
>     MT8196
>   media: mediatek: encoder: Add MT8196 encoder compatible data
> 
>  .../media/mediatek,vcodec-encoder.yaml        |  12 +
>  .../mediatek/vcodec/common/mtk_vcodec_fw.c    |  19 +
>  .../mediatek/vcodec/common/mtk_vcodec_fw.h    |   2 +
>  .../vcodec/common/mtk_vcodec_fw_priv.h        |   1 +
>  .../vcodec/common/mtk_vcodec_fw_vcp.c         |   6 +
>  .../platform/mediatek/vcodec/encoder/Makefile |   1 +
>  .../mediatek/vcodec/encoder/mtk_vcodec_enc.c  |  37 +-
>  .../vcodec/encoder/mtk_vcodec_enc_drv.c       |  28 +
>  .../vcodec/encoder/mtk_vcodec_enc_drv.h       |  15 +-
>  .../vcodec/encoder/venc/venc_common_if.c      | 678 ++++++++++++++++++
>  .../vcodec/encoder/venc/venc_h264_if.c        |   8 +-
>  .../mediatek/vcodec/encoder/venc_drv_if.c     |   3 +-
>  .../mediatek/vcodec/encoder/venc_drv_if.h     |  11 +-
>  .../mediatek/vcodec/encoder/venc_ipi_msg.h    |  26 +
>  .../mediatek/vcodec/encoder/venc_vpu_if.c     |  51 +-
>  15 files changed, 843 insertions(+), 55 deletions(-)
>  create mode 100644 drivers/media/platform/mediatek/vcodec/encoder/venc/venc_common_if.c