Re: [PATCH v2 5/6] dt-bindings: media: mediatek: encoder: Add encoder dt-bindings for MT8196

["Irui Wang (王瑞)" <Irui.Wang@mediatek.com>]

Dear Rob,

Thanks for your reviewing.

On Thu, 2025-06-05 at 13:26 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Wed, May 28, 2025 at 02:36:31PM +0800, Irui Wang wrote:
> > Add MT8196 encoder compatible string, which will reference VCP
> > device.
> > 
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> >  .../bindings/media/mediatek,vcodec-encoder.yaml      | 12
> > ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index ebc615584f92..7675391d7eb0 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -24,6 +24,7 @@ properties:
> >                - mediatek,mt8188-vcodec-enc
> >                - mediatek,mt8192-vcodec-enc
> >                - mediatek,mt8195-vcodec-enc
> > +              - mediatek,mt8196-vcodec-enc
> >        - items:
> >            - const: mediatek,mt8186-vcodec-enc
> >            - const: mediatek,mt8183-vcodec-enc
> > @@ -76,6 +77,17 @@ required:
> >    - iommus
> > 
> >  allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mediatek,mt8196-vcodec-enc
> > +
> > +    then:
> > +      required:
> > +        - mediatek,vcp
> 
> Where is this property defined?
The definition is missing, we will add it in next patch.
> 
> > +
> >    - if:
> >        properties:
> >          compatible:
> > --
> > 2.45.2
> >