From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lorenzo Bianconi
<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>,
Hans Ulli Kroll
<ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
Jakub Kicinski <kubakici-5tc4TXWwyLM@public.gmane.org>,
Michal Schmidt <mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver
Date: Wed, 01 Aug 2018 11:41:33 +0300 [thread overview]
Message-ID: <87600u8on6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180801082844.GB4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> (Stanislaw Gruszka's message of "Wed, 1 Aug 2018 10:28:45 +0200")
Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> On Wed, Aug 01, 2018 at 10:32:12AM +0300, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
>>
>> > Add Kconfig and Makefiles for mt76x0 driver. Now the driver
>> > can be build.
>> >
>> > Signed-off-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> > ---
>> > drivers/net/wireless/mediatek/mt76/Kconfig | 7 +++++++
>> > drivers/net/wireless/mediatek/mt76/Makefile | 1 +
>> > drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++
>> > 3 files changed, 15 insertions(+)
>> > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
>> >
>> > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig
>> > index 69906c733a1c..850611ad347a 100644
>> > --- a/drivers/net/wireless/mediatek/mt76/Kconfig
>> > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
>> > @@ -9,6 +9,13 @@ config MT76x2_COMMON
>> > tristate
>> > depends on MT76_CORE
>> >
>> > +config MT76x0U
>> > + tristate "MediaTek MT76x0U (USB) support"
>> > + depends on MAC80211
>> > + depends on USB
>> > + help
>> > + This adds support for MT7610U-based wireless USB dongles.
>>
>> Does it make sense to add a Kconfig option for every mt76 device? I'm
>> worried that soon we have over a dozen of them. I can understand having
>> separate options to enable PCI or USB devices, but I don't see the
>> benefit for anything more finegrained than that.
>
> I think it does make sense for AP/home routers and other embedded
> devices.
How much of memory savings are we talking about?
--
Kalle Valo
next prev parent reply other threads:[~2018-08-01 8:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 12:40 [PATCH v3 00/14] Add mt76x0 driver Stanislaw Gruszka
[not found] ` <1533040864-9026-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-31 12:40 ` [PATCH v3 01/14] mt76x0: core files Stanislaw Gruszka
[not found] ` <1533040864-9026-2-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-02 18:52 ` Kalle Valo
2018-08-02 18:52 ` Kalle Valo
2018-07-31 12:40 ` [PATCH v3 02/14] mt76x0: mac files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 03/14] mt76x0: usb files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 04/14] mt76x0: mcu files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 05/14] mt76x0: phy files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 06/14] mt76x0: init files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 07/14] mt76x0: eeprom files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 08/14] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-31 12:40 ` [PATCH v3 09/14] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-31 12:41 ` [PATCH v3 10/14] mt76x0: main file Stanislaw Gruszka
2018-07-31 12:41 ` [PATCH v3 11/14] mt76: add more states Stanislaw Gruszka
2018-07-31 12:41 ` [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
[not found] ` <1533040864-9026-13-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-01 7:32 ` Kalle Valo
[not found] ` <8736vy1r0j.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org>
2018-08-01 8:28 ` Stanislaw Gruszka
[not found] ` <20180801082844.GB4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-01 8:41 ` Kalle Valo [this message]
[not found] ` <87600u8on6.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2018-08-01 8:59 ` Stanislaw Gruszka
[not found] ` <20180801085913.GC4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-02 17:11 ` Kalle Valo
2018-07-31 12:41 ` [PATCH v3 13/14] mt76x0: disable HW before probe Stanislaw Gruszka
2018-07-31 12:41 ` [PATCH v3 14/14] mt76x0: load firmware from mediatek subdir Stanislaw Gruszka
2018-08-01 7:39 ` [PATCH v3 00/14] Add mt76x0 driver Kalle Valo
[not found] ` <87y3dqzga9.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org>
2018-08-01 8:13 ` Lorenzo Bianconi
[not found] ` <20180801081346.GA4794-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-08-01 8:19 ` Kalle Valo
2018-08-01 8:25 ` Stanislaw Gruszka
[not found] ` <20180801082508.GA4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-01 8:40 ` Lorenzo Bianconi
[not found] ` <20180801084056.GB4794-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-08-02 17:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87600u8on6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=kubakici-5tc4TXWwyLM@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nbd-Vt+b4OUoWG0@public.gmane.org \
--cc=sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox