Re: [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver

[Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Wed, Aug 01, 2018 at 10:32:12AM +0300, Kalle Valo wrote:
> Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> 
> > Add Kconfig and Makefiles for mt76x0 driver. Now the driver
> > can be build.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/net/wireless/mediatek/mt76/Kconfig         | 7 +++++++
> >  drivers/net/wireless/mediatek/mt76/Makefile        | 1 +
> >  drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++
> >  3 files changed, 15 insertions(+)
> >  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig
> > index 69906c733a1c..850611ad347a 100644
> > --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> > @@ -9,6 +9,13 @@ config MT76x2_COMMON
> >  	tristate
> >  	depends on MT76_CORE
> >  
> > +config MT76x0U
> > +	tristate "MediaTek MT76x0U (USB) support"
> > +	depends on MAC80211
> > +	depends on USB
> > +	help
> > +	  This adds support for MT7610U-based wireless USB dongles.
> 
> Does it make sense to add a Kconfig option for every mt76 device? I'm
> worried that soon we have over a dozen of them. I can understand having
> separate options to enable PCI or USB devices, but I don't see the
> benefit for anything more finegrained than that.

I think it does make sense for AP/home routers and other embedded
devices.

Stanislaw