From: Robin Murphy <robin.murphy@arm.com>
To: Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>
Cc: Evan Green <evgreen@chromium.org>, Tomasz Figa <tfiga@google.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
anan.sun@mediatek.com, cui.zhang@mediatek.com,
chao.hao@mediatek.com, edison.hsieh@mediatek.com
Subject: Re: [PATCH v3 1/7] iommu/mediatek: Correct the flush_iotlb_all callback
Date: Mon, 14 Oct 2019 15:06:49 +0100 [thread overview]
Message-ID: <9aa2e356-d234-df21-7203-ce569c232e02@arm.com> (raw)
In-Reply-To: <1571035101-4213-2-git-send-email-yong.wu@mediatek.com>
On 14/10/2019 07:38, Yong Wu wrote:
> Use the correct tlb_flush_all instead of the original one.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: 4d689b619445 ("iommu/io-pgtable-arm-v7s: Convert to IOMMU API TLB sync")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 67a483c..76b9388 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -447,7 +447,7 @@ static size_t mtk_iommu_unmap(struct iommu_domain *domain,
>
> static void mtk_iommu_flush_iotlb_all(struct iommu_domain *domain)
> {
> - mtk_iommu_tlb_sync(mtk_iommu_get_m4u_data());
> + mtk_iommu_tlb_flush_all(mtk_iommu_get_m4u_data());
> }
>
> static void mtk_iommu_iotlb_sync(struct iommu_domain *domain,
>
next prev parent reply other threads:[~2019-10-14 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 6:38 [PATCH v3 0/7] Improve tlb range flush Yong Wu
2019-10-14 6:38 ` [PATCH v3 1/7] iommu/mediatek: Correct the flush_iotlb_all callback Yong Wu
2019-10-14 14:06 ` Robin Murphy [this message]
2019-10-14 6:38 ` [PATCH v3 2/7] iommu/mediatek: Add pgtlock in the iotlb_sync Yong Wu
2019-10-14 6:38 ` [PATCH v3 3/7] iommu/mediatek: Use gather to achieve the tlb range flush Yong Wu
2019-10-14 14:21 ` Robin Murphy
2019-10-15 5:26 ` Yong Wu
2019-10-15 11:38 ` Robin Murphy
2019-10-14 6:38 ` [PATCH v3 4/7] iommu/mediatek: Delete the leaf in the tlb flush Yong Wu
2019-10-14 14:22 ` Robin Murphy
[not found] ` <20c74c20-864e-88af-3c58-ad3bb7600bcc-5wv7dgnIgG8@public.gmane.org>
2019-10-15 5:25 ` Yong Wu
2019-10-15 11:24 ` Robin Murphy
2019-10-14 6:38 ` [PATCH v3 5/7] iommu/mediatek: Move the tlb_sync into tlb_flush Yong Wu
2019-10-14 6:38 ` [PATCH v3 6/7] iommu/mediatek: Use writel for TLB range invalidation Yong Wu
2019-10-14 14:04 ` Robin Murphy
[not found] ` <c87e2a9c-5ed3-e44c-3b17-067db173eae9-5wv7dgnIgG8@public.gmane.org>
2019-10-15 5:25 ` Yong Wu
2019-10-14 6:38 ` [PATCH v3 7/7] iommu/mediatek: Reduce the tlb flush timeout value Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aa2e356-d234-df21-7203-ce569c232e02@arm.com \
--to=robin.murphy@arm.com \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=cui.zhang@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=edison.hsieh@mediatek.com \
--cc=evgreen@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will.deacon@arm.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox