From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>,
Paolo Abeni <pabeni@redhat.com>
Cc: devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
linux-kernel@vger.kernel.org,
"Daniel Golle" <daniel@makrotopia.org>,
linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Frank Wunderlich" <linux@fw-web.de>,
"Rob Herring" <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
Date: Tue, 25 Jun 2024 10:51:31 +0200 [thread overview]
Message-ID: <9c498e37-df8b-469e-818a-9b1c9f2b1a3c@collabora.com> (raw)
In-Reply-To: <750a60a6-4585-4bd2-97be-cf944e51fbdb@leemhuis.info>
Il 25/06/24 07:56, Linux regression tracking (Thorsten Leemhuis) ha scritto:
> On 17.06.24 13:08, Arınç ÜNAL wrote:
>> On 17/06/2024 11:33, Linux regression tracking (Thorsten Leemhuis) wrote:
>> [...]
>> I've submitted a patch series that fixes the regression. Angelo argued
>> against the way the regression is fixed. I've very clearly argued back why
>> I find Angelo's approach wrong. There's been no response back. I don't
>> understand why reverting the patch is the likely outcome
>
> Long story short: because that how things like that are handled in the
> Linux kernel project, as Linus wants it like that. See some of the
> quotes from https://docs.kernel.org/process/handling-regressions.html
> for details.
>
>> whilst the
>> standing argument points towards applying the said patch series. If a
>> revert happens before this discussion with Angelo finalises, this will set
>> a precedent that will tell maintainers that they can have their way by just
>> not replying to the ongoing discussions.
>>
>> That said, the decision of resolving the regression by either reverting the
>> patch or applying the patch series shall not depend on whether or not
>> Angelo is pleased but rather there're no counter-arguments left on the
>> points brought, meaning the decision shall be made depending on the
>> argument that stands.
>>
>> Therefore, I suggest that unless Angelo responds back with a
>> counter-argument in the window of a week or two, as you've described, my
>> patch series shall be applied.
>
> It looks more and more like we are stuck here (or was there progress and
> I just missed it?) while the 6.10 final is slowly getting closer. Hence:
>
> AngeloGioacchino, should we ask the net maintainers to revert
> 868ff5f4944aa9 ("net: dsa: mt7530-mdio: read PHY address of switch from
> device tree") for now to resolve this regression? Reminder, there is
> nothing wrong with that commit per se afaik, it just exposes a problem
> that needs to be fixed first before it can be reapplied.
>
To be clear on this: I asked for the commit to be fixed such that it guarantees
backwards compatibility with older device trees.
If no fix comes, then I guess that we should ask them to revert this commit
until a fix is available.
I don't like this situation, either, btw.
Ciao!
Angelo
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
next prev parent reply other threads:[~2024-06-25 8:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 20:48 [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64 Frank Wunderlich
2024-05-17 2:17 ` Arınç ÜNAL
2024-05-17 6:27 ` Frank Wunderlich
2024-05-23 10:44 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-31 5:40 ` Thorsten Leemhuis
2024-05-31 6:10 ` Arınç ÜNAL
2024-06-06 8:26 ` Thorsten Leemhuis
2024-06-06 9:01 ` Arınç ÜNAL
2024-06-06 9:34 ` Thorsten Leemhuis
2024-06-07 14:03 ` Paolo Abeni
2024-06-07 14:15 ` Thorsten Leemhuis
2024-06-11 11:30 ` Thorsten Leemhuis
2024-06-11 11:38 ` Arınç ÜNAL
2024-06-11 12:28 ` AngeloGioacchino Del Regno
2024-06-11 12:56 ` Arınç ÜNAL
2024-06-11 13:03 ` AngeloGioacchino Del Regno
2024-06-11 18:15 ` Arınç ÜNAL
2024-06-17 8:33 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-17 11:08 ` Arınç ÜNAL
2024-06-25 5:56 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-25 6:17 ` Arınç ÜNAL
2024-06-25 6:57 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-25 8:17 ` Arınç ÜNAL
2024-06-25 8:49 ` AngeloGioacchino Del Regno
2024-06-26 3:07 ` Arınç ÜNAL
2024-06-25 8:51 ` AngeloGioacchino Del Regno [this message]
2024-07-01 6:16 ` Linux regression tracking (Thorsten Leemhuis)
2024-07-01 7:02 ` Aw: " Frank Wunderlich
2024-07-01 7:44 ` Arınç ÜNAL
2024-07-01 8:04 ` Linux regression tracking (Thorsten Leemhuis)
2024-07-01 8:15 ` Arınç ÜNAL
2024-07-30 9:41 ` AngeloGioacchino Del Regno
2024-07-30 11:22 ` arinc.unal
2024-07-30 11:38 ` arinc.unal
2024-07-30 16:04 ` Krzysztof Kozlowski
2024-07-30 16:22 ` Daniel Golle
2024-07-30 16:38 ` Arınç ÜNAL
2024-07-31 5:29 ` Krzysztof Kozlowski
2024-07-31 7:55 ` Arınç ÜNAL
2024-05-31 6:12 ` Arınç ÜNAL
2024-05-31 6:18 ` Frank Wunderlich
2024-05-31 6:27 ` Arınç ÜNAL
2024-05-17 13:17 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c498e37-df8b-469e-818a-9b1c9f2b1a3c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox