* [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0
@ 2024-09-25 7:15 Macpaul Lin
2024-09-25 7:22 ` Macpaul Lin
2024-09-25 7:54 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-09-25 7:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin, Sen Chu,
Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai,
Tommy Chen
During inspecting dtbs_check errors, we found the power domain
setting of DPI node "dp_intf0" is missing. Add power domain setting
to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 +
1 file changed, 1 insertion(+)
Changes for v1:
- This patch is related to adding mt8195-dp-intf to DT schema fix for
- http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml
- patch: https://lore.kernel.org/all/20240924103156.13119-6-macpaul.lin@mediatek.com/
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ade685ed2190..6218bd7abb05 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3252,6 +3252,7 @@ dp_intf0: dp-intf@1c015000 {
compatible = "mediatek,mt8195-dp-intf";
reg = <0 0x1c015000 0 0x1000>;
interrupts = <GIC_SPI 657 IRQ_TYPE_LEVEL_HIGH 0>;
+ power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
clocks = <&vdosys0 CLK_VDO0_DP_INTF0_DP_INTF>,
<&vdosys0 CLK_VDO0_DP_INTF0>,
<&apmixedsys CLK_APMIXED_TVDPLL1>;
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0
2024-09-25 7:15 [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0 Macpaul Lin
@ 2024-09-25 7:22 ` Macpaul Lin
2024-09-25 7:54 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-09-25 7:22 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai, Tommy Chen
On 9/25/24 15:15, Macpaul Lin wrote:
> During inspecting dtbs_check errors, we found the power domain
> setting of DPI node "dp_intf0" is missing. Add power domain setting
> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
>
> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
[snip]
Sorry there is a typo in the Signed-off-by.
I'll send v2 to correct this.
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0
2024-09-25 7:15 [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0 Macpaul Lin
2024-09-25 7:22 ` Macpaul Lin
@ 2024-09-25 7:54 ` AngeloGioacchino Del Regno
2024-09-25 7:56 ` Macpaul Lin
1 sibling, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-09-25 7:54 UTC (permalink / raw)
To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai, Tommy Chen
Il 25/09/24 09:15, Macpaul Lin ha scritto:
> During inspecting dtbs_check errors, we found the power domain
> setting of DPI node "dp_intf0" is missing. Add power domain setting
> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
>
> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
You missed a Suggested-by tag here :-)
after which,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0
2024-09-25 7:54 ` AngeloGioacchino Del Regno
@ 2024-09-25 7:56 ` Macpaul Lin
0 siblings, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-09-25 7:56 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai, Tommy Chen
On 9/25/24 15:54, AngeloGioacchino Del Regno wrote:
> Il 25/09/24 09:15, Macpaul Lin ha scritto:
>> During inspecting dtbs_check errors, we found the power domain
>> setting of DPI node "dp_intf0" is missing. Add power domain setting
>> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
>>
>> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>
> You missed a Suggested-by tag here :-)
>
> after which,
>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
>
Got it! I'll send v3 update later.
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-25 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 7:15 [PATCH] arm64: dts: mediatek: mt8195: Add power domain for dp_intf0 Macpaul Lin
2024-09-25 7:22 ` Macpaul Lin
2024-09-25 7:54 ` AngeloGioacchino Del Regno
2024-09-25 7:56 ` Macpaul Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox