From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Cc: Chen Wang <chen.wang@linux.dev>,
linux-pwm@vger.kernel.org, Sven Peter <sven@kernel.org>,
Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Paul Walmsley <pjw@kernel.org>,
Samuel Holland <samuel.holland@sifive.com>,
Michael Walle <mwalle@kernel.org>,
Inochi Amaoto <inochiama@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Hammer Hsieh <hammerh0314@gmail.com>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>,
Alexey Charkov <alchark@gmail.com>,
Sean Anderson <sean.anderson@linux.dev>,
Michal Simek <michal.simek@amd.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev, imx@lists.linux.dev,
linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-riscv@lists.infradead.org, sophgo@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays
Date: Mon, 6 Jul 2026 12:39:34 +0200 [thread overview]
Message-ID: <akuFirxGTqu_gt4O@monoceros> (raw)
In-Reply-To: <bc697542-b1e2-41c2-af36-b708ca4aad5c@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
Hello,
On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Uwe,
>
> On 6/7/26 09:19, Uwe Kleine-König (The Capable Hub) wrote:
> > Hello Chen,
> >
> > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote:
> > > On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote:
> > > > - Use a single space in a of_device_id array terminator; A single space
> > > > after the opening { and before the closing } in non-empty
> > > > initializers;
> > > > - No comma after an array terminator;
> > > > - Also no trailing comma after a named initializer iff the
> > > iff -> if
> >
> > This is actually intended. iff = "if and only if", see e.g.
> > https://en.wikipedia.org/wiki/If_and_only_if .
>
> I agree this scientific idiomatic expression is not well known
> by non-native English speakers, and using the expanded form is
> just simpler to review (thinking at non-native English speaker
> reading your commit in the future).
fine for me, I'll fixup to
- Also no trailing comma after a named initializer if (and only if) the
closing } is on the same line;
when applying.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-06 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 15:14 [PATCH v1 0/5] pwm: Unify arrays of various *_device_id Uwe Kleine-König (The Capable Hub)
2026-07-05 15:14 ` [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-06 0:33 ` Chen Wang
2026-07-06 7:19 ` Uwe Kleine-König (The Capable Hub)
2026-07-06 8:28 ` Philippe Mathieu-Daudé
2026-07-06 10:39 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-07-06 10:41 ` Krzysztof Kozlowski
2026-07-06 8:00 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akuFirxGTqu_gt4O@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=Frank.Li@nxp.com \
--cc=alchark@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=chen.wang@linux.dev \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=groeck@chromium.org \
--cc=hammerh0314@gmail.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=inochiama@gmail.com \
--cc=j@jannau.net \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=magnus.damm@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=mwalle@kernel.org \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=orsonzhai@gmail.com \
--cc=paul@crapouillou.net \
--cc=peter.griffin@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=pjw@kernel.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel.holland@sifive.com \
--cc=sbranden@broadcom.com \
--cc=sean.anderson@linux.dev \
--cc=sophgo@lists.linux.dev \
--cc=sven@kernel.org \
--cc=vz@mleia.com \
--cc=wens@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox