[PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure

[PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure

[Pan Chuang]

devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in pinctrl drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (4):
  pinctrl: airoha: Remove redundant dev_err()
  pinctrl: bcm: Remove redundant dev_err()
  pinctrl: intel: Remove redundant dev_err_probe()
  pinctrl: Remove redundant dev_err()/dev_err_probe()

 drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
 drivers/pinctrl/bcm/pinctrl-nsp-gpio.c  | 5 +----
 drivers/pinctrl/intel/pinctrl-intel.c   | 2 +-
 drivers/pinctrl/pinctrl-aw9523.c        | 2 +-
 drivers/pinctrl/pinctrl-mcp23s08.c      | 5 +----
 drivers/pinctrl/pinctrl-stmfx.c         | 4 +---
 6 files changed, 6 insertions(+), 16 deletions(-)

-- 
2.34.1

[PATCH 1/4] pinctrl: airoha: Remove redundant dev_err()

[Pan Chuang]

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
index 04b4424c688b..abfb018f207e 100644
--- a/drivers/pinctrl/airoha/pinctrl-airoha.c
+++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
@@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
 
 	err = devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED,
 				dev_name(dev), pinctrl);
-	if (err) {
-		dev_err(dev, "error requesting irq %d: %d\n", irq, err);
+	if (err)
 		return err;
-	}
 
 	return devm_gpiochip_add_data(dev, gc, pinctrl);
 }
-- 
2.34.1

Re: [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err()

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> ---
>  drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index 04b4424c688b..abfb018f207e 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
>  
>  	err = devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED,
>  				dev_name(dev), pinctrl);
> -	if (err) {
> -		dev_err(dev, "error requesting irq %d: %d\n", irq, err);
> +	if (err)
>  		return err;
> -	}
>  
>  	return devm_gpiochip_add_data(dev, gc, pinctrl);
>  }
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]