* [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure
@ 2026-07-31 3:54 Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
0 siblings, 2 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Peter Chen, Pawel Laszczak, Roger Quadros, Greg Kroah-Hartman,
Minas Harutyunyan, Peter Griffin, André Draszik,
Tudor Ambarus, Thinh Nguyen, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Joel Stanley,
Andrew Jeffery, Neal Liu, Cristian Birsan, Nicolas Ferre,
Alexandre Belloni, Claudiu Beznea, Herve Codina, Thierry Reding,
Jonathan Hunter, Mathias Nyman, Al Cooper,
Broadcom internal kernel review list, Florian Fainelli,
Souradeep Chowdhury, Chunfeng Yun, Heikki Krogerus,
Matthias Brugger, AngeloGioacchino Del Regno,
open list:CADENCE USB3 DRD IP DRIVER, open list,
moderated list:GOOGLE TENSOR SoC SUPPORT,
open list:GOOGLE TENSOR SoC SUPPORT,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OMAP USB SUPPORT,
moderated list:ARM/ASPEED MACHINE SUPPORT,
open list:RENESAS RZ/N1 USBF CONTROLLER DRIVER,
open list:TEGRA ARCHITECTURE SUPPORT,
open list:ARM/QUALCOMM MAILING LIST,
moderated list:MEDIATEK USB3 DRD IP DRIVER
Cc: Pan Chuang
devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls
in usb drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.
Pan Chuang (11):
usb: cdns3: Remove redundant dev_err()
usb: common: usb-conn-gpio: Remove redundant dev_err()
usb: dwc2: gadget: Remove redundant dev_err()
usb: dwc3: Remove redundant dev_err()/dev_err_probe()
usb: gadget: Remove redundant dev_err()
usb: host: xhci-tegra: Remove redundant dev_err()
usb: misc: Remove redundant dev_err()/dev_err_probe()
usb: mtu3: Remove redundant dev_err()
usb: phy: Remove redundant dev_err()/dev_err_probe()
usb: renesas_usbhs: Remove redundant dev_err()
usb: typec: Remove redundant dev_err()/dev_err_probe()
drivers/usb/cdns3/core.c | 4 +---
drivers/usb/cdns3/drd.c | 4 +---
drivers/usb/common/usb-conn-gpio.c | 8 ++------
drivers/usb/dwc2/gadget.c | 4 +---
drivers/usb/dwc3/dwc3-google.c | 4 +---
drivers/usb/dwc3/dwc3-imx.c | 2 +-
drivers/usb/dwc3/dwc3-imx8mp.c | 4 +---
drivers/usb/dwc3/dwc3-keystone.c | 5 +----
drivers/usb/dwc3/dwc3-omap.c | 5 +----
drivers/usb/gadget/udc/aspeed-vhub/core.c | 4 +---
drivers/usb/gadget/udc/aspeed_udc.c | 4 +---
drivers/usb/gadget/udc/atmel_usba_udc.c | 5 +----
drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
drivers/usb/gadget/udc/renesas_usbf.c | 8 ++------
drivers/usb/gadget/udc/snps_udc_plat.c | 4 +---
drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
drivers/usb/host/xhci-tegra.c | 8 ++------
drivers/usb/misc/brcmstb-usb-pinmap.c | 9 ++-------
drivers/usb/misc/qcom_eud.c | 2 +-
drivers/usb/mtu3/mtu3_core.c | 4 +---
drivers/usb/phy/phy-ab8500-usb.c | 12 +++---------
drivers/usb/phy/phy-generic.c | 3 +--
drivers/usb/phy/phy-gpio-vbus-usb.c | 5 +----
drivers/usb/renesas_usbhs/mod.c | 4 +---
drivers/usb/typec/anx7411.c | 4 +---
drivers/usb/typec/hd3ss3220.c | 4 +---
drivers/usb/typec/mux/it5205.c | 2 +-
drivers/usb/typec/tcpm/tcpci_maxim_core.c | 3 +--
drivers/usb/typec/tcpm/tcpci_mt6360.c | 1 -
drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
30 files changed, 35 insertions(+), 102 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 08/11] usb: mtu3: Remove redundant dev_err()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
1 sibling, 0 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Chunfeng Yun, Greg Kroah-Hartman,
open list:MEDIATEK USB3 DRD IP DRIVER,
moderated list:MEDIATEK USB3 DRD IP DRIVER,
moderated list:MEDIATEK USB3 DRD IP DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/mtu3/mtu3_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index a40bf5bad2d5..990e2e8e6bc2 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -973,10 +973,8 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb)
ret = devm_request_threaded_irq(dev, mtu->irq, NULL, mtu3_irq,
IRQF_ONESHOT, dev_name(dev), mtu);
- if (ret) {
- dev_err(dev, "request irq %d failed!\n", mtu->irq);
+ if (ret)
goto irq_err;
- }
/* power down device IP for power saving by default */
mtu3_stop(mtu);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-08-05 12:12 ` Heikki Krogerus
1 sibling, 1 reply; 4+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Matthias Brugger,
AngeloGioacchino Del Regno, open list:USB TYPEC CLASS, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/typec/anx7411.c | 4 +---
drivers/usb/typec/hd3ss3220.c | 4 +---
drivers/usb/typec/mux/it5205.c | 2 +-
drivers/usb/typec/tcpm/tcpci_maxim_core.c | 3 +--
drivers/usb/typec/tcpm/tcpci_mt6360.c | 1 -
drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
6 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index 41df115912b9..2c41e00819f8 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -1529,10 +1529,8 @@ static int anx7411_i2c_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
"anx7411-intp", plat);
- if (ret) {
- dev_err(dev, "fail to request irq\n");
+ if (ret)
goto free_wq;
- }
if (anx7411_typec_check_connection(plat))
dev_err(dev, "check status\n");
diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 3e39b800e6b5..64648686bf8b 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -436,10 +436,8 @@ static int hd3ss3220_probe(struct i2c_client *client)
IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
dev_name(hd3ss3220->dev), hd3ss3220);
- if (ret < 0) {
- dev_err(hd3ss3220->dev, "failed to get ID irq: %d\n", ret);
+ if (ret < 0)
goto err_put_fwnode;
- }
}
typec_cap.prefer_role = TYPEC_NO_PREFERRED_ROLE;
diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
index 5e1a120b2e3b..2ab2ba6a3cbd 100644
--- a/drivers/usb/typec/mux/it5205.c
+++ b/drivers/usb/typec/mux/it5205.c
@@ -250,7 +250,7 @@ static int it5205_probe(struct i2c_client *client)
if (ret) {
typec_mux_unregister(it->mux);
typec_switch_unregister(it->sw);
- return dev_err_probe(dev, ret, "Failed to request irq\n");
+ return ret;
}
}
diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
index 998693a61839..52dbbbe53691 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
@@ -542,8 +542,7 @@ static int max_tcpci_probe(struct i2c_client *client)
(IRQF_TRIGGER_LOW | IRQF_ONESHOT), dev_name(chip->dev),
chip);
if (ret < 0)
- return dev_err_probe(&client->dev, ret,
- "IRQ initialization failed\n");
+ return ret;
ret = devm_device_init_wakeup(chip->dev);
if (ret)
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 881ffacbfd77..d4010ea5183b 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -167,7 +167,6 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(mti->dev, mti->irq, NULL, mt6360_irq, IRQF_ONESHOT,
dev_name(&pdev->dev), mti);
if (ret) {
- dev_err(mti->dev, "Failed to register irq\n");
tcpci_unregister_port(mti->tcpci);
return ret;
}
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
index 7d6c75c70985..2e85cb05ed37 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
@@ -168,7 +168,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL, mt6370_irq_handler,
IRQF_ONESHOT, dev_name(dev), priv);
if (ret)
- return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+ return ret;
device_init_wakeup(dev, true);
dev_pm_set_wake_irq(dev, irq);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-08-05 12:12 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2026-08-05 12:12 UTC (permalink / raw)
To: Pan Chuang
Cc: Greg Kroah-Hartman, Matthias Brugger, AngeloGioacchino Del Regno,
open list:USB TYPEC CLASS, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Fri, Jul 31, 2026 at 11:54:45AM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/anx7411.c | 4 +---
> drivers/usb/typec/hd3ss3220.c | 4 +---
> drivers/usb/typec/mux/it5205.c | 2 +-
> drivers/usb/typec/tcpm/tcpci_maxim_core.c | 3 +--
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 1 -
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
> index 41df115912b9..2c41e00819f8 100644
> --- a/drivers/usb/typec/anx7411.c
> +++ b/drivers/usb/typec/anx7411.c
> @@ -1529,10 +1529,8 @@ static int anx7411_i2c_probe(struct i2c_client *client)
> IRQF_TRIGGER_FALLING |
> IRQF_ONESHOT,
> "anx7411-intp", plat);
> - if (ret) {
> - dev_err(dev, "fail to request irq\n");
> + if (ret)
> goto free_wq;
> - }
>
> if (anx7411_typec_check_connection(plat))
> dev_err(dev, "check status\n");
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 3e39b800e6b5..64648686bf8b 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -436,10 +436,8 @@ static int hd3ss3220_probe(struct i2c_client *client)
> IRQF_TRIGGER_RISING |
> IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> dev_name(hd3ss3220->dev), hd3ss3220);
> - if (ret < 0) {
> - dev_err(hd3ss3220->dev, "failed to get ID irq: %d\n", ret);
> + if (ret < 0)
> goto err_put_fwnode;
> - }
> }
>
> typec_cap.prefer_role = TYPEC_NO_PREFERRED_ROLE;
> diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
> index 5e1a120b2e3b..2ab2ba6a3cbd 100644
> --- a/drivers/usb/typec/mux/it5205.c
> +++ b/drivers/usb/typec/mux/it5205.c
> @@ -250,7 +250,7 @@ static int it5205_probe(struct i2c_client *client)
> if (ret) {
> typec_mux_unregister(it->mux);
> typec_switch_unregister(it->sw);
> - return dev_err_probe(dev, ret, "Failed to request irq\n");
> + return ret;
> }
> }
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> index 998693a61839..52dbbbe53691 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> @@ -542,8 +542,7 @@ static int max_tcpci_probe(struct i2c_client *client)
> (IRQF_TRIGGER_LOW | IRQF_ONESHOT), dev_name(chip->dev),
> chip);
> if (ret < 0)
> - return dev_err_probe(&client->dev, ret,
> - "IRQ initialization failed\n");
> + return ret;
>
> ret = devm_device_init_wakeup(chip->dev);
> if (ret)
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 881ffacbfd77..d4010ea5183b 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -167,7 +167,6 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(mti->dev, mti->irq, NULL, mt6360_irq, IRQF_ONESHOT,
> dev_name(&pdev->dev), mti);
> if (ret) {
> - dev_err(mti->dev, "Failed to register irq\n");
> tcpci_unregister_port(mti->tcpci);
> return ret;
> }
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 7d6c75c70985..2e85cb05ed37 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -168,7 +168,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(dev, irq, NULL, mt6370_irq_handler,
> IRQF_ONESHOT, dev_name(dev), priv);
> if (ret)
> - return dev_err_probe(dev, ret, "Failed to allocate irq\n");
> + return ret;
>
> device_init_wakeup(dev, true);
> dev_pm_set_wake_irq(dev, irq);
> --
> 2.34.1
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-05 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-08-05 12:12 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox