[PATCH 0/2] MT8186 pinctrl properties adjustments

[PATCH 0/2] MT8186 pinctrl properties adjustments

[Allen-KH Cheng]

Based on tag: next-20220720, linux-next/master.

In commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
PIN_CONFIG_DRIVE_STRENGTH_UA"), added support for using
drive-strength-microamp instead of mediatek,drive-strength-adv.

We replace the custom mediatek,drive-strength-adv property with
'drive-strength-microamp' in the mt8186 pinctrl dt-binding which
have a clearer meaning and is more standardized, also add
gpio-line-names property used in devicetrees to describe pin names.

Allen-KH Cheng (2):
  dt-bindings: pinctrl: mt8186: Add gpio-line-names property
  dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp

 .../bindings/pinctrl/pinctrl-mt8186.yaml      | 31 +++----------------
 1 file changed, 5 insertions(+), 26 deletions(-)

-- 
2.18.0

[PATCH 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property

[Allen-KH Cheng]

Add the 'gpio-line-names' property to mt8186-pinctrl, as this will be
used in devicetrees to describe pin names.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 8a2bb8608291..6784885edc5c 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -28,6 +28,8 @@ properties:
   gpio-ranges:
     maxItems: 1
 
+  gpio-line-names: true
+
   reg:
     description: |
       Physical address base for gpio base registers. There are 8 different GPIO
-- 
2.18.0

[PATCH 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp

[Allen-KH Cheng]

Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
drive-strength-microamp instead of mediatek,drive-strength-adv.

Similarly to the mt8192 and mt8195, there's no user of property
'mediatek,drive-strength-adv', hence removing it is safe.

Fixes: 338e953f1bd1(dt-bindings: pinctrl: mt8186: add pinctrl file and binding document)
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 .../bindings/pinctrl/pinctrl-mt8186.yaml      | 29 ++-----------------
 1 file changed, 3 insertions(+), 26 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 6784885edc5c..1eeb885ce0c6 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -107,31 +107,8 @@ patternProperties:
           drive-strength:
             enum: [2, 4, 6, 8, 10, 12, 14, 16]
 
-          mediatek,drive-strength-adv:
-            description: |
-              Describe the specific driving setup property.
-              For I2C pins, the existing generic driving setup can only support
-              2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they
-              can support 0.125/0.25/0.5/1mA adjustment. If we enable specific
-              driving setup, the existing generic setup will be disabled.
-              The specific driving setup is controlled by E1E0EN.
-              When E1=0/E0=0, the strength is 0.125mA.
-              When E1=0/E0=1, the strength is 0.25mA.
-              When E1=1/E0=0, the strength is 0.5mA.
-              When E1=1/E0=1, the strength is 1mA.
-              EN is used to enable or disable the specific driving setup.
-              Valid arguments are described as below:
-              0: (E1, E0, EN) = (0, 0, 0)
-              1: (E1, E0, EN) = (0, 0, 1)
-              2: (E1, E0, EN) = (0, 1, 0)
-              3: (E1, E0, EN) = (0, 1, 1)
-              4: (E1, E0, EN) = (1, 0, 0)
-              5: (E1, E0, EN) = (1, 0, 1)
-              6: (E1, E0, EN) = (1, 1, 0)
-              7: (E1, E0, EN) = (1, 1, 1)
-              So the valid arguments are from 0 to 7.
-            $ref: /schemas/types.yaml#/definitions/uint32
-            enum: [0, 1, 2, 3, 4, 5, 6, 7]
+          drive-strength-microamp:
+            enum: [125, 250, 500, 1000]
 
           bias-pull-down:
             oneOf:
@@ -293,7 +270,7 @@ examples:
           pinmux = <PINMUX_GPIO127__FUNC_SCL0>,
                    <PINMUX_GPIO128__FUNC_SDA0>;
           bias-pull-up = <MTK_PULL_SET_RSEL_001>;
-          mediatek,drive-strength-adv = <7>;
+          drive-strength-microamp = <1000>;
         };
       };
     };
-- 
2.18.0

Re: [PATCH 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp

[AngeloGioacchino Del Regno]

Il 25/07/22 12:02, Allen-KH Cheng ha scritto:
> Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> drive-strength-microamp instead of mediatek,drive-strength-adv.
> 
> Similarly to the mt8192 and mt8195, there's no user of property
> 'mediatek,drive-strength-adv', hence removing it is safe.
> 
> Fixes: 338e953f1bd1(dt-bindings: pinctrl: mt8186: add pinctrl file and binding document)
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

The fixes tag format is wrong... Please fix that:

Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding 
document")

(sorry about wrapped line if you see it, that's supposed to be one line!).

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property

[AngeloGioacchino Del Regno]

Il 25/07/22 12:02, Allen-KH Cheng ha scritto:
> Add the 'gpio-line-names' property to mt8186-pinctrl, as this will be
> used in devicetrees to describe pin names.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
> index 8a2bb8608291..6784885edc5c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
> @@ -28,6 +28,8 @@ properties:
>     gpio-ranges:
>       maxItems: 1
>   
> +  gpio-line-names: true
> +
>     reg:
>       description: |
>         Physical address base for gpio base registers. There are 8 different GPIO

Re: [PATCH 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp

[allen-kh.cheng]

Hi Angelo,

On Mon, 2022-07-25 at 12:35 +0200, AngeloGioacchino Del Regno wrote:
> Il 25/07/22 12:02, Allen-KH Cheng ha scritto:
> > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> > drive-strength-microamp instead of mediatek,drive-strength-adv.
> > 
> > Similarly to the mt8192 and mt8195, there's no user of property
> > 'mediatek,drive-strength-adv', hence removing it is safe.
> > 
> > Fixes: 338e953f1bd1(dt-bindings: pinctrl: mt8186: add pinctrl file
> > and binding document)
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> 
> The fixes tag format is wrong... Please fix that:
> 
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file
> and binding 
> document")
> 
> (sorry about wrapped line if you see it, that's supposed to be one
> line!).
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 

Thanks for your comments, Will update in next version.

BRs
Allen