Re: [PATCH v3 1/2] dt-bindings: pinctrl: mediatek: Add support for mt8188

[hui.liu <hui.liu@mediatek.com>]

On Thu, 2022-07-28 at 12:47 +0200, AngeloGioacchino Del Regno wrote:
> > +
> > +title: MediaTek MT8188 Pin Controller
> > +
> > +maintainers:
> > +  - Hui Liu <hui.liu@mediatek.com>
> > +
> > +description: |
> > +  The MediaTek's MT8188 Pin controller is used to control SoC
> > pins.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt8188-pinctrl
> > +
> > +  gpio-controller: true
> > +
> > +  '#gpio-cells':
> > +    description: |
> > +      Number of cells in GPIO specifier, should be two. The first
> > cell
> > +      is the pin number, the second cell is used to specify
> > optional
> > +      parameters which are defined in <dt-bindings/gpio/gpio.h>.
> > +    const: 2
> > +
> > +  gpio-ranges:
> > +    maxItems: 1
> > +
> 
> Please allow to specify gpio names
> 
>    gpio-line-names: true
> 
> after which:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 

Hi Angelo,

Thanks for your comment, I will add gpio-line-names in next version.

Regards,
  Hui