* [PATCH 00/11] thermal: clean up output of make W=1 @ 2019-11-06 13:28 Amit Kucheria 2019-11-06 13:28 ` [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity Amit Kucheria 0 siblings, 1 reply; 4+ messages in thread From: Amit Kucheria @ 2019-11-06 13:28 UTC (permalink / raw) To: linux-kernel, edubezval, Amit Daniel Kachhap, Amit Kucheria, Bartlomiej Zolnierkiewicz, Daniel Lezcano, Guillaume La Roque, Heiko Stuebner, Javi Merino, Jonathan Hunter, Jun Nie, Krzysztof Kozlowski, Kukjin Kim, Matthias Brugger, Shawn Guo, Thierry Reding, Viresh Kumar, Zhang Rui Cc: linux-samsung-soc, linux-pm, linux-rockchip, linux-mediatek, linux-tegra, linux-amlogic, linux-arm-kernel Cleanup output of make W=1 inside drivers/thermal. This should allow us to focus on real issues that tend to get lost in the noise much better. There is no functional change. This series was generate on top of linux-next from 20191105. Regards, Amit Amit Kucheria (11): thermal: of-thermal: Appease the kernel-doc deity thermal: cpu_cooling: Appease the kernel-doc deity thermal: step_wise: Appease the kernel-doc deity thermal: devfreq_cooling: Appease the kernel-doc deity thermal: max77620: Appease the kernel-doc deity thermal: mediatek: Appease the kernel-doc deity thermal: rockchip: Appease the kernel-doc deity thermal: samsung: Appease the kernel-doc deity thermal: tegra: Appease the kernel-doc deity thermal: amlogic: Appease the kernel-doc deity thermal: zx2967: Appease the kernel-doc deity drivers/thermal/amlogic_thermal.c | 6 +++++- drivers/thermal/cpu_cooling.c | 1 + drivers/thermal/devfreq_cooling.c | 3 ++- drivers/thermal/fair_share.c | 4 ++-- drivers/thermal/gov_bang_bang.c | 4 ++-- drivers/thermal/max77620_thermal.c | 2 +- drivers/thermal/mtk_thermal.c | 12 ++++++------ drivers/thermal/of-thermal.c | 2 +- drivers/thermal/rockchip_thermal.c | 22 ++++++++++++++++------ drivers/thermal/samsung/exynos_tmu.c | 5 ++++- drivers/thermal/step_wise.c | 4 ++-- drivers/thermal/tegra/soctherm.c | 15 +++++++++++++-- drivers/thermal/user_space.c | 4 ++-- drivers/thermal/zx2967_thermal.c | 1 + 14 files changed, 58 insertions(+), 27 deletions(-) -- 2.17.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity 2019-11-06 13:28 [PATCH 00/11] thermal: clean up output of make W=1 Amit Kucheria @ 2019-11-06 13:28 ` Amit Kucheria 2019-11-07 2:19 ` Viresh Kumar 0 siblings, 1 reply; 4+ messages in thread From: Amit Kucheria @ 2019-11-06 13:28 UTC (permalink / raw) To: linux-kernel, edubezval, Amit Daniel Kachhap, Amit Kucheria, Bartlomiej Zolnierkiewicz, Daniel Lezcano, Guillaume La Roque, Heiko Stuebner, Javi Merino, Jonathan Hunter, Jun Nie, Krzysztof Kozlowski, Kukjin Kim, Matthias Brugger, Shawn Guo, Thierry Reding, Viresh Kumar, Zhang Rui Cc: linux-mediatek, linux-arm-kernel, linux-pm Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- drivers/thermal/mtk_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index acf4854cbb8b8..76e30603d4d58 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; -/** +/* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 * temperature sensors. We use each bank to measure a certain area of the @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { .sensor_mux_values = mt8173_mux_values, }; -/** +/* * The MT2701 thermal controller has one bank, which can read up to * three temperature sensors simultaneously. The MT2701 has a total of 3 * temperature sensors. @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .sensor_mux_values = mt2701_mux_values, }; -/** +/* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 * temperature sensors. @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .sensor_mux_values = mt7622_mux_values, }; -/** +/* * The MT8183 thermal controller has one bank for the current SW framework. * The MT8183 has a total of 6 temperature sensors. * There are two thermal controller to control the six sensor. @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { * data, and this indeed needs the temperatures of the individual banks * for making better decisions. */ - static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, .num_banks = MT8183_NUM_SENSORS_PER_ZONE, @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { /** * raw_to_mcelsius - convert a raw ADC value to mcelsius - * @mt: The thermal controller + * @mt: The thermal controller + * @sensno: sensor number * @raw: raw ADC value * * This converts the raw ADC value to mcelsius using the SoC specific -- 2.17.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity 2019-11-06 13:28 ` [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity Amit Kucheria @ 2019-11-07 2:19 ` Viresh Kumar 2019-11-07 2:20 ` Viresh Kumar 0 siblings, 1 reply; 4+ messages in thread From: Viresh Kumar @ 2019-11-07 2:19 UTC (permalink / raw) To: Amit Kucheria Cc: Amit Kucheria, Heiko Stuebner, Bartlomiej Zolnierkiewicz, Amit Daniel Kachhap, Daniel Lezcano, linux-mediatek, linux-kernel, Krzysztof Kozlowski, Jonathan Hunter, edubezval, Kukjin Kim, Guillaume La Roque, linux-pm, Matthias Brugger, Thierry Reding, Jun Nie, Javi Merino, Shawn Guo, Zhang Rui, linux-arm-kernel On 06-11-19, 18:58, Amit Kucheria wrote: > Replace a comment starting with /** by simply /* to avoid having it > interpreted as a kernel-doc comment. Describe missing function > parameters where needed. > > Fixes up the following warnings when compiled with make W=1: > > linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand > function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = > ' > linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand > function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = > ' > linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand > function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = > ' > linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand > function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = > ' > linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter > or member 'sensno' not described in 'raw_to_mcelsius' > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > drivers/thermal/mtk_thermal.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index acf4854cbb8b8..76e30603d4d58 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; > static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; > static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; > > -/** > +/* > * The MT8173 thermal controller has four banks. Each bank can read up to > * four temperature sensors simultaneously. The MT8173 has a total of 5 > * temperature sensors. We use each bank to measure a certain area of the > @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { > .sensor_mux_values = mt8173_mux_values, > }; > > -/** > +/* > * The MT2701 thermal controller has one bank, which can read up to > * three temperature sensors simultaneously. The MT2701 has a total of 3 > * temperature sensors. > @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { > .sensor_mux_values = mt2701_mux_values, > }; > > -/** > +/* > * The MT2712 thermal controller has one bank, which can read up to > * four temperature sensors simultaneously. The MT2712 has a total of 4 > * temperature sensors. > @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { > .sensor_mux_values = mt7622_mux_values, > }; > > -/** > +/* > * The MT8183 thermal controller has one bank for the current SW framework. > * The MT8183 has a total of 6 temperature sensors. > * There are two thermal controller to control the six sensor. > @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { > * data, and this indeed needs the temperatures of the individual banks > * for making better decisions. > */ > - > static const struct mtk_thermal_data mt8183_thermal_data = { > .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, > .num_banks = MT8183_NUM_SENSORS_PER_ZONE, > @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { > > /** > * raw_to_mcelsius - convert a raw ADC value to mcelsius > - * @mt: The thermal controller > + * @mt: The thermal controller > + * @sensno: sensor number > * @raw: raw ADC value This doesn't look related to $subject > * > * This converts the raw ADC value to mcelsius using the SoC specific > -- > 2.17.1 -- viresh _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity 2019-11-07 2:19 ` Viresh Kumar @ 2019-11-07 2:20 ` Viresh Kumar 0 siblings, 0 replies; 4+ messages in thread From: Viresh Kumar @ 2019-11-07 2:20 UTC (permalink / raw) To: Amit Kucheria Cc: Amit Kucheria, Heiko Stuebner, Bartlomiej Zolnierkiewicz, Amit Daniel Kachhap, Daniel Lezcano, linux-mediatek, linux-kernel, Krzysztof Kozlowski, Jonathan Hunter, edubezval, Kukjin Kim, Guillaume La Roque, linux-pm, Matthias Brugger, Thierry Reding, Jun Nie, Javi Merino, Shawn Guo, Zhang Rui, linux-arm-kernel On 07-11-19, 07:49, Viresh Kumar wrote: > On 06-11-19, 18:58, Amit Kucheria wrote: > > Replace a comment starting with /** by simply /* to avoid having it > > interpreted as a kernel-doc comment. Describe missing function > > parameters where needed. > > > > Fixes up the following warnings when compiled with make W=1: > > > > linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand > > function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = > > ' > > linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand > > function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = > > ' > > linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand > > function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = > > ' > > linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand > > function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = > > ' > > linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter > > or member 'sensno' not described in 'raw_to_mcelsius' > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > --- > > drivers/thermal/mtk_thermal.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > > index acf4854cbb8b8..76e30603d4d58 100644 > > --- a/drivers/thermal/mtk_thermal.c > > +++ b/drivers/thermal/mtk_thermal.c > > @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; > > static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; > > static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; > > > > -/** > > +/* > > * The MT8173 thermal controller has four banks. Each bank can read up to > > * four temperature sensors simultaneously. The MT8173 has a total of 5 > > * temperature sensors. We use each bank to measure a certain area of the > > @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { > > .sensor_mux_values = mt8173_mux_values, > > }; > > > > -/** > > +/* > > * The MT2701 thermal controller has one bank, which can read up to > > * three temperature sensors simultaneously. The MT2701 has a total of 3 > > * temperature sensors. > > @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { > > .sensor_mux_values = mt2701_mux_values, > > }; > > > > -/** > > +/* > > * The MT2712 thermal controller has one bank, which can read up to > > * four temperature sensors simultaneously. The MT2712 has a total of 4 > > * temperature sensors. > > @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { > > .sensor_mux_values = mt7622_mux_values, > > }; > > > > -/** > > +/* > > * The MT8183 thermal controller has one bank for the current SW framework. > > * The MT8183 has a total of 6 temperature sensors. > > * There are two thermal controller to control the six sensor. > > @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { > > * data, and this indeed needs the temperatures of the individual banks > > * for making better decisions. > > */ > > - > > static const struct mtk_thermal_data mt8183_thermal_data = { > > .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, > > .num_banks = MT8183_NUM_SENSORS_PER_ZONE, > > @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { > > > > /** > > * raw_to_mcelsius - convert a raw ADC value to mcelsius > > - * @mt: The thermal controller > > + * @mt: The thermal controller > > + * @sensno: sensor number > > * @raw: raw ADC value > > This doesn't look related to $subject I take this statement back :) Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> -- viresh _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-07 2:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-06 13:28 [PATCH 00/11] thermal: clean up output of make W=1 Amit Kucheria 2019-11-06 13:28 ` [PATCH 06/11] thermal: mediatek: Appease the kernel-doc deity Amit Kucheria 2019-11-07 2:19 ` Viresh Kumar 2019-11-07 2:20 ` Viresh Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox