[PATCH v6 1/4] media: dt-bindings: mediatek: Add AIE face detection support for MT8188

[PATCH v6 1/4] media: dt-bindings: mediatek: Add AIE face detection support for MT8188

[Sarang Chaudhari]

Add YAML device tree bindings for the MediaTek AI Engine (AIE) hardware
accelerator found in MT8188 SoCs. The AIE provides hardware-accelerated
face detection, facial landmark detection, and face attribute analysis
capabilities.

Add a MAINTAINERS entry covering the binding, the UAPI header and the
driver directory.

Signed-off-by: Sarang Chaudhari <sarang.chaudhari@mediatek.com>
---
Changes in v6:
- Add ipe-smi-larb12 clock to the binding (was missing in v5 binding
  but present in v5 dtsi).
- Remove iommus from required properties (made optional for platforms
  that can operate without IOMMU).
- Add mediatek,larb as an optional property.
- Improve description text.

Changes in v5:
- Modify the description to make it more concise.
- Delete the description of reg.
- Modify the description of iommus and delete the maxItems of iommus.
- Delete all mediatek,larb.
- Modify the name of clock, change _ to -.

Changes in v4:
- Remove address-cells and size-cells.
- Remove larb12 related content.
- Update id content.

Changes in v3: None

Changes in v2:
- Fix coding style.

 .../bindings/media/mediatek,mt8188-aie.yaml   | 85 +++++++++++++++++++
 MAINTAINERS                                   | 10 +++
 2 files changed, 95 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
new file mode 100644
index 0000000..ab888f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
@@ -0,0 +1,85 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mt8188-aie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek AI Engine (AIE) for Face Detection
+
+maintainers:
+  - Fish Wu <fish.wu@mediatek.com>
+  - Bo Kong <bo.kong@mediatek.com>
+
+description: |
+  The MediaTek AI Engine (AIE) provides hardware-accelerated face detection,
+  facial landmark detection, and face attribute analysis. It is found in the
+  IPE (Image Processing Engine) subsystem of MediaTek SoCs.
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt8188-aie
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: clock for imgsys main ipe
+      - description: clock for ipe fdvt
+      - description: clock for ipe smi larb12
+      - description: clock for ipe top
+
+  clock-names:
+    items:
+      - const: img-ipe
+      - const: ipe-fdvt
+      - const: ipe-smi-larb12
+      - const: ipe-top
+
+  power-domains:
+    maxItems: 1
+
+  iommus:
+    maxItems: 1
+
+  mediatek,larb:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: phandle to the local arbiter (LARB) node
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - power-domains
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/mediatek,mt8188-clk.h>
+    #include <dt-bindings/power/mediatek,mt8188-power.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        aie@15310000 {
+            compatible = "mediatek,mt8188-aie";
+            reg = <0 0x15310000 0 0x1000>;
+            interrupts = <GIC_SPI 600 IRQ_TYPE_LEVEL_HIGH 0>;
+            clocks = <&imgsys CLK_IMGSYS_MAIN_IPE>,
+                     <&ipesys CLK_IPE_FDVT>,
+                     <&ipesys CLK_IPE_SMI_LARB12>,
+                     <&ipesys CLK_IPESYS_TOP>;
+            clock-names = "img-ipe", "ipe-fdvt",
+                          "ipe-smi-larb12", "ipe-top";
+            power-domains = <&spm MT8188_POWER_DOMAIN_IPE>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index afb7487..fa631d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3,6 +3,16 @@ M:	Felix Fietkau <nbd@nbd.name>
 S:	Maintained
 F:	drivers/net/ethernet/mediatek/
 
+MEDIATEK MT8188 AIE DRIVER
+M:	Fish Wu <fish.wu@mediatek.com>
+M:	Bo Kong <bo.kong@mediatek.com>
+L:	linux-media@vger.kernel.org
+L:	linux-mediatek@lists.infradead.org (moderated for non-subscribers)
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
+F:	drivers/media/platform/mediatek/aie/
+F:	include/uapi/linux/mtk_aie_v4l2_controls.h
+
 MEDIATEK MDP DRIVER
 M:	Minghsiu Tsai <minghsiu.tsai@mediatek.com>
 S:	Supported
-- 
2.45.2

Re: [PATCH v6 1/4] media: dt-bindings: mediatek: Add AIE face detection support for MT8188

[Krzysztof Kozlowski]

On 05/06/2026 10:28, Sarang Chaudhari wrote:
> Add YAML device tree bindings for the MediaTek AI Engine (AIE) hardware
> accelerator found in MT8188 SoCs. The AIE provides hardware-accelerated
> face detection, facial landmark detection, and face attribute analysis
> capabilities.

v6 and still not following Linux kernel process...


Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

> +F:	Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
> +F:	drivers/media/platform/mediatek/aie/

There is no such directory. Apply THIS patch and test.

> +F:	include/uapi/linux/mtk_aie_v4l2_controls.h
> +
>  MEDIATEK MDP DRIVER
>  M:	Minghsiu Tsai <minghsiu.tsai@mediatek.com>
>  S:	Supported


Best regards,
Krzysztof